Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Philippe Waroquiers <philippe.waroquiers@skynet.be>
To: Eli Zaretskii <eliz@gnu.org>
Cc: gdb-patches@sourceware.org
Subject: Re: RFA [PATCH] Implement 'catch syscall' for gdbserver
Date: Fri, 30 Aug 2013 16:02:00 -0000	[thread overview]
Message-ID: <1377878558.3041.8.camel@soleil> (raw)
In-Reply-To: <83k3j3dvyq.fsf@gnu.org>

On Fri, 2013-08-30 at 18:44 +0300, Eli Zaretskii wrote:
> > From: Philippe Waroquiers <philippe.waroquiers@skynet.be>
> > Date: Fri, 30 Aug 2013 17:26:28 +0200
> > 
> > This is the 2nd version of the patch implementing 'catch syscalls' for
> > gdbserver.
> > First version was sent in an RFC (no feedback yet, so here is a completed
> > and tested RFA ready version).
> > Tested (no regression) on linux amd64, native and gdbserver.
> > Manually tested with a patched Valgrind gdbserver.
> 
> Thanks.  The documentation parts are OK, but please be sure to leave 2
> spaces between sentences (some of them have only one in this
> changeset).
Oops, sorry, even if my brain knows it, my fingers don't.

Fixed the occurences detected with:
grep '\. [^ ]' patch.txt
+	     max 8+1 characters for a sysno. If the resulting
+	      /* catch_packet too big. Fallback to less efficient
+in hex) should be reported to @value{GDBN}. If no syscall @var{sysno}
+will filter it if this signal is not catched. It is however more efficient
+  /* Fill SYSNO with the syscall nr trapped. Fill SYSRET with the
+/* 1 if some (or all) syscalls are catched. */

Thanks for the quick review

Philippe


  reply	other threads:[~2013-08-30 16:02 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-30 15:26 Philippe Waroquiers
2013-08-30 15:44 ` Eli Zaretskii
2013-08-30 16:02   ` Philippe Waroquiers [this message]
2013-09-04 22:38 ` Philippe Waroquiers
2013-09-10 18:05 ` Sergio Durigan Junior
2013-09-10 18:07 ` added to 7.7-branch wiki: " Joel Brobecker
2013-09-19  5:29 ` Sergio Durigan Junior
2013-09-19 23:30   ` Philippe Waroquiers
2013-09-20  5:07     ` Sergio Durigan Junior

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1377878558.3041.8.camel@soleil \
    --to=philippe.waroquiers@skynet.be \
    --cc=eliz@gnu.org \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox