From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16283 invoked by alias); 30 Aug 2013 16:02:37 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 16273 invoked by uid 89); 30 Aug 2013 16:02:37 -0000 Received: from mailrelay004.isp.belgacom.be (HELO mailrelay004.isp.belgacom.be) (195.238.6.170) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 30 Aug 2013 16:02:37 +0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=3.0 required=5.0 tests=AWL,BAYES_00,CK_HELO_DYNAMIC_SPLIT_IP,HELO_DYNAMIC_SPLIT_IP,KHOP_THREADED,SPF_SOFTFAIL,TVD_RCVD_IP autolearn=no version=3.3.2 X-HELO: mailrelay004.isp.belgacom.be X-Belgacom-Dynamic: yes X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: ApMBANbAIFJtgbcb/2dsb2JhbAANTYc0vSiBNIMYAQEBBCNWEAsUAQMCAiYCAlcGE65kdJI1gSmOSweCaIE0A6x7 Received: from 27.183-129-109.adsl-dyn.isp.belgacom.be (HELO [192.168.1.6]) ([109.129.183.27]) by relay.skynet.be with ESMTP; 30 Aug 2013 18:02:34 +0200 Subject: Re: RFA [PATCH] Implement 'catch syscall' for gdbserver From: Philippe Waroquiers To: Eli Zaretskii Cc: gdb-patches@sourceware.org In-Reply-To: <83k3j3dvyq.fsf@gnu.org> References: <1377876388.3041.3.camel@soleil> <83k3j3dvyq.fsf@gnu.org> Content-Type: text/plain; charset="UTF-8" Date: Fri, 30 Aug 2013 16:02:00 -0000 Message-ID: <1377878558.3041.8.camel@soleil> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-SW-Source: 2013-08/txt/msg00934.txt.bz2 On Fri, 2013-08-30 at 18:44 +0300, Eli Zaretskii wrote: > > From: Philippe Waroquiers > > Date: Fri, 30 Aug 2013 17:26:28 +0200 > > > > This is the 2nd version of the patch implementing 'catch syscalls' for > > gdbserver. > > First version was sent in an RFC (no feedback yet, so here is a completed > > and tested RFA ready version). > > Tested (no regression) on linux amd64, native and gdbserver. > > Manually tested with a patched Valgrind gdbserver. > > Thanks. The documentation parts are OK, but please be sure to leave 2 > spaces between sentences (some of them have only one in this > changeset). Oops, sorry, even if my brain knows it, my fingers don't. Fixed the occurences detected with: grep '\. [^ ]' patch.txt + max 8+1 characters for a sysno. If the resulting + /* catch_packet too big. Fallback to less efficient +in hex) should be reported to @value{GDBN}. If no syscall @var{sysno} +will filter it if this signal is not catched. It is however more efficient + /* Fill SYSNO with the syscall nr trapped. Fill SYSRET with the +/* 1 if some (or all) syscalls are catched. */ Thanks for the quick review Philippe