[patch] Make test messages unique in mi-var-block.exp

[patch] Make test messages unique in mi-var-block.exp

[Hafiz Abid Qadeer]

[-- Attachment #1: Type: text/plain, Size: 314 bytes --]

Hi,
This is another little patch to make the test messages unique in  
mi-var-block.exp. Tested by running the test. Is it ok?

Regards,
Abid

gdb/testsuite:

2013-01-21  Hafiz Abid Qadeer<abidh@codesourcery.com>

         PR gdb/13443
         * gdb.mi/mi-var-block.exp: Make test messages unique.


[-- Attachment #2: mi-var-block.patch --]
[-- Type: text/x-patch, Size: 2442 bytes --]

diff --git a/gdb/testsuite/gdb.mi/mi-var-block.exp b/gdb/testsuite/gdb.mi/mi-var-block.exp
index ddc6a89..5e7f482 100644
--- a/gdb/testsuite/gdb.mi/mi-var-block.exp
+++ b/gdb/testsuite/gdb.mi/mi-var-block.exp
@@ -51,13 +51,13 @@ mi_gdb_test "-var-create foo * foo" \
 # step to "foo = 123;"
 mi_step_to "do_block_tests" "" "var-cmd.c" \
     [gdb_get_line_number "foo = 123;"] \
-    "step at do_block_test"
+    "step at do_block_test 1"
 
 
 # Be paranoid and assume 3.2 created foo
 mi_gdb_test "-var-delete foo" \
 	"\\^error,msg=\"Variable object not found\"" \
-	"delete var foo"
+	"delete var foo 1"
 
 
 # Test: c_variable-3.3
@@ -67,7 +67,7 @@ mi_create_varobj "foo" "foo" "create local variable foo"
 # step to "foo2 = 123;"
 mi_step_to "do_block_tests" "" "var-cmd.c" \
     [gdb_get_line_number "foo2 = 123;"] \
-    "step at do_block_test"
+    "step at do_block_test 2"
 
 # Test: c_variable-3.4
 # Desc: check foo, cb changed
@@ -78,7 +78,7 @@ mi_gdb_test "-var-update *" \
 # step to "foo = 321;"
 mi_step_to "do_block_tests" "" "var-cmd.c" \
     [gdb_get_line_number "foo = 321;"] \
-    "step at do_block_test"
+    "step at do_block_test 3"
 
 # Test: c_variable-3.5
 # Desc: create inner block foo
@@ -87,7 +87,7 @@ mi_create_varobj "inner_foo" "foo" "create local variable inner_foo"
 # step to "foo2 = 0;"
 mi_step_to "do_block_tests" "" "var-cmd.c" \
     [gdb_get_line_number "foo2 = 0;"] \
-    "step at do_block_test"
+    "step at do_block_test 4"
 
 # Test: c_variable-3.6
 # Desc: create foo2
@@ -119,7 +119,7 @@ mi_gdb_test "-var-delete inner_foo" \
 # step to "foo = 0;"
 mi_step_to "do_block_tests" "" "var-cmd.c" \
     [gdb_get_line_number "foo = 0;"] \
-    "step at do_block_test"
+    "step at do_block_test 5"
 
 # Test: c_variable-3.8
 # Desc: check that foo2 out of scope (known gdb problem)
@@ -132,7 +132,7 @@ clear_xfail *-*-*
 # step to "cb = 21;"
 mi_step_to "do_block_tests" "" "var-cmd.c" \
     [gdb_get_line_number "cb = 21;"] \
-    "step at do_block_test"
+    "step at do_block_test 6"
 
 # Test: c_variable-3.9
 # Desc: check that only cb is in scope (known gdb problem)
@@ -159,7 +159,7 @@ mi_gdb_test "-var-update cb" \
 # Done with block tests
 mi_gdb_test "-var-delete foo" \
 	"\\^done,ndeleted=\"1\"" \
-	"delete var foo"
+	"delete var foo 2"
 
 mi_gdb_test "-var-delete foo2" \
 	"\\^done,ndeleted=\"1\"" \

Re: [patch] Make test messages unique in mi-var-block.exp

[Tom Tromey]

>>>>> "Abid" == Hafiz Abid Qadeer <hafiz_abid@mentor.com> writes:

Abid> 2013-01-21  Hafiz Abid Qadeer<abidh@codesourcery.com>

Abid>          PR gdb/13443
Abid>          * gdb.mi/mi-var-block.exp: Make test messages unique.

Wrong formatting in the ChangeLog entry: two spaces between your name
and the "<", and the content lines must start with tab characters.

The patch is ok with that fixed.

Tom

Re: [patch] Make test messages unique in mi-var-block.exp

[Hafiz Abid Qadeer]

On 23/01/13 21:50:28, Tom Tromey wrote:
> >>>>> "Abid" == Hafiz Abid Qadeer <hafiz_abid@mentor.com> writes:
> 
> Abid> 2013-01-21  Hafiz Abid Qadeer<abidh@codesourcery.com>
> 
> Abid>          PR gdb/13443
> Abid>          * gdb.mi/mi-var-block.exp: Make test messages unique.
> 
> Wrong formatting in the ChangeLog entry: two spaces between your name
> and the "<", and the content lines must start with tab characters.
> 
> The patch is ok with that fixed.
> 
> Tom
> 

Thanks for review. Committed after making the suggested changes.

Regards,
Abid