From: Yao Qi <yao@codesourcery.com>
To: <gdb-patches@sourceware.org>
Subject: [PATCH] Fix -Wformat-extra-args warning.
Date: Mon, 26 Nov 2012 09:24:00 -0000 [thread overview]
Message-ID: <1353921793-26314-1-git-send-email-yao@codesourcery.com> (raw)
Hi,
When compile gdb with clang, the following warning is reported,
git/gdb/symtab.c:3784:24: error: data argument not used by format string [-Werror,-Wformat-extra-args]
It is obvious to me, but review is still welcome.
gdb:
2012-11-26 Yao Qi <yao@codesourcery.com>
* symtab.c (symtab_symbol_info): Fix a -Wformat-extra-args
warning.
---
gdb/symtab.c | 9 +++++----
1 files changed, 5 insertions(+), 4 deletions(-)
diff --git a/gdb/symtab.c b/gdb/symtab.c
index 05943cf..e8cd861 100644
--- a/gdb/symtab.c
+++ b/gdb/symtab.c
@@ -3778,10 +3778,11 @@ symtab_symbol_info (char *regexp, enum search_domain kind, int from_tty)
search_symbols (regexp, kind, 0, (char **) NULL, &symbols);
old_chain = make_cleanup_free_search_symbols (symbols);
- printf_filtered (regexp
- ? "All %ss matching regular expression \"%s\":\n"
- : "All defined %ss:\n",
- classnames[kind], regexp);
+ if (regexp != NULL)
+ printf_filtered ("All %ss matching regular expression \"%s\":\n",
+ classnames[kind], regexp);
+ else
+ printf_filtered ("All defined %ss:\n", classnames[kind]);
for (p = symbols; p != NULL; p = p->next)
{
--
1.7.7.6
next reply other threads:[~2012-11-26 9:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-26 9:24 Yao Qi [this message]
2012-11-26 9:37 ` Joel Brobecker
2012-11-27 7:26 ` Yao Qi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1353921793-26314-1-git-send-email-yao@codesourcery.com \
--to=yao@codesourcery.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox