From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16610 invoked by alias); 26 Nov 2012 09:24:01 -0000 Received: (qmail 16585 invoked by uid 22791); 26 Nov 2012 09:24:01 -0000 X-SWARE-Spam-Status: No, hits=-3.8 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL X-Spam-Check-By: sourceware.org Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 26 Nov 2012 09:23:56 +0000 Received: from svr-orw-exc-10.mgc.mentorg.com ([147.34.98.58]) by relay1.mentorg.com with esmtp id 1Tcuux-0005CM-Ck from Yao_Qi@mentor.com for gdb-patches@sourceware.org; Mon, 26 Nov 2012 01:23:55 -0800 Received: from SVR-ORW-FEM-02.mgc.mentorg.com ([147.34.96.206]) by SVR-ORW-EXC-10.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.4675); Mon, 26 Nov 2012 01:23:54 -0800 Received: from qiyao.dyndns.org.dyndns.org (147.34.91.1) by svr-orw-fem-02.mgc.mentorg.com (147.34.96.168) with Microsoft SMTP Server id 14.1.289.1; Mon, 26 Nov 2012 01:23:51 -0800 From: Yao Qi To: Subject: [PATCH] Fix -Wformat-extra-args warning. Date: Mon, 26 Nov 2012 09:24:00 -0000 Message-ID: <1353921793-26314-1-git-send-email-yao@codesourcery.com> MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-11/txt/msg00642.txt.bz2 Hi, When compile gdb with clang, the following warning is reported, git/gdb/symtab.c:3784:24: error: data argument not used by format string [-Werror,-Wformat-extra-args] It is obvious to me, but review is still welcome. gdb: 2012-11-26 Yao Qi * symtab.c (symtab_symbol_info): Fix a -Wformat-extra-args warning. --- gdb/symtab.c | 9 +++++---- 1 files changed, 5 insertions(+), 4 deletions(-) diff --git a/gdb/symtab.c b/gdb/symtab.c index 05943cf..e8cd861 100644 --- a/gdb/symtab.c +++ b/gdb/symtab.c @@ -3778,10 +3778,11 @@ symtab_symbol_info (char *regexp, enum search_domain kind, int from_tty) search_symbols (regexp, kind, 0, (char **) NULL, &symbols); old_chain = make_cleanup_free_search_symbols (symbols); - printf_filtered (regexp - ? "All %ss matching regular expression \"%s\":\n" - : "All defined %ss:\n", - classnames[kind], regexp); + if (regexp != NULL) + printf_filtered ("All %ss matching regular expression \"%s\":\n", + classnames[kind], regexp); + else + printf_filtered ("All defined %ss:\n", classnames[kind]); for (p = symbols; p != NULL; p = p->next) { -- 1.7.7.6