Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Yao Qi <yao@codesourcery.com>
To: <gdb-patches@sourceware.org>
Subject: [obv] Use existed/supported commands in mi-cmd-param-changed.exp
Date: Mon, 19 Nov 2012 15:05:00 -0000	[thread overview]
Message-ID: <1353337462-7952-1-git-send-email-yao@codesourcery.com> (raw)

Hi,
'maint set show-debug-regs' is an i386 specific command, so it doesn't
exist on other ports, such as arm.  We'll see these errors in gdb.sum,

  ERROR: Undefined command "maint set show-debug-regs on".
  ERROR: Undefined command "maint set show-debug-regs off".

'set circular-trace-buffer' is not supported on ports other than x86
and x86_64.

This patch removes the test to remove the test to command
'maint set show-debug-regs', and replace 'set circular-trace-buffer'
with 'set remotecache' which exists on all ports.

I'll commit it in two days if no one has comments.

gdb/testsuite:

2012-11-19  Yao Qi  <yao@codesourcery.com>

	* gdb.mi/mi-cmd-param-changed.exp (test_command_param_changed):
	Don't test 'maint set show-debug-regs'.
	Use command 'set remotecache' instead of
	'set circular-trace-buffer'.
---
 gdb/testsuite/gdb.mi/mi-cmd-param-changed.exp |   12 +++++-------
 1 files changed, 5 insertions(+), 7 deletions(-)

diff --git a/gdb/testsuite/gdb.mi/mi-cmd-param-changed.exp b/gdb/testsuite/gdb.mi/mi-cmd-param-changed.exp
index 8c2195c..7786f90 100644
--- a/gdb/testsuite/gdb.mi/mi-cmd-param-changed.exp
+++ b/gdb/testsuite/gdb.mi/mi-cmd-param-changed.exp
@@ -52,7 +52,7 @@ proc test_command_param_changed { } { with_test_prefix "cmd param" {
 	"\"set scheduler-locking stepr\" no event"
 
 
-    foreach command { "circular-trace-buffer" "check type" } {
+    foreach command { "remotecache" "check type" } {
 
 	# The default value of each command option may be different, so we first
 	# set it to 'off', and this may or may not trigger MI notification.
@@ -81,12 +81,10 @@ proc test_command_param_changed { } { with_test_prefix "cmd param" {
     }
 
     # No notification is emitted for 'maint set' commands.
-    foreach command { "profile" "show-debug-regs" } {
-	foreach boolean_opt { "on" "off" } {
-	    mi_gdb_test "maint set ${command} ${boolean_opt}" \
-		"\\&\"maint set ${command} ${boolean_opt}\\\\n\"\r\n\\^done" \
-		"\"maint set ${command} ${boolean_opt}\""
-	}
+    foreach boolean_opt { "on" "off" } {
+	mi_gdb_test "maint set profile ${boolean_opt}" \
+	    "\\&\"maint set profile ${boolean_opt}\\\\n\"\r\n\\^done" \
+	    "\"maint set profile ${boolean_opt}\""
     }
 
     # Full command parameters are included in the notification when a
-- 
1.7.7.6


             reply	other threads:[~2012-11-19 15:05 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-19 15:05 Yao Qi [this message]
2012-11-19 15:32 ` Tom Tromey
2012-11-20  2:55   ` Yao Qi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1353337462-7952-1-git-send-email-yao@codesourcery.com \
    --to=yao@codesourcery.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox