From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11548 invoked by alias); 19 Nov 2012 15:05:16 -0000 Received: (qmail 11500 invoked by uid 22791); 19 Nov 2012 15:05:15 -0000 X-SWARE-Spam-Status: No, hits=-3.8 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL X-Spam-Check-By: sourceware.org Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 19 Nov 2012 15:04:45 +0000 Received: from svr-orw-fem-01.mgc.mentorg.com ([147.34.98.93]) by relay1.mentorg.com with esmtp id 1TaStw-0002Cl-BQ from Yao_Qi@mentor.com for gdb-patches@sourceware.org; Mon, 19 Nov 2012 07:04:44 -0800 Received: from SVR-ORW-FEM-03.mgc.mentorg.com ([147.34.97.39]) by svr-orw-fem-01.mgc.mentorg.com over TLS secured channel with Microsoft SMTPSVC(6.0.3790.4675); Mon, 19 Nov 2012 07:04:44 -0800 Received: from qiyao.dyndns.org.dyndns.org (147.34.91.1) by svr-orw-fem-03.mgc.mentorg.com (147.34.97.39) with Microsoft SMTP Server id 14.1.289.1; Mon, 19 Nov 2012 07:04:03 -0800 From: Yao Qi To: Subject: [obv] Use existed/supported commands in mi-cmd-param-changed.exp Date: Mon, 19 Nov 2012 15:05:00 -0000 Message-ID: <1353337462-7952-1-git-send-email-yao@codesourcery.com> MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-11/txt/msg00499.txt.bz2 Hi, 'maint set show-debug-regs' is an i386 specific command, so it doesn't exist on other ports, such as arm. We'll see these errors in gdb.sum, ERROR: Undefined command "maint set show-debug-regs on". ERROR: Undefined command "maint set show-debug-regs off". 'set circular-trace-buffer' is not supported on ports other than x86 and x86_64. This patch removes the test to remove the test to command 'maint set show-debug-regs', and replace 'set circular-trace-buffer' with 'set remotecache' which exists on all ports. I'll commit it in two days if no one has comments. gdb/testsuite: 2012-11-19 Yao Qi * gdb.mi/mi-cmd-param-changed.exp (test_command_param_changed): Don't test 'maint set show-debug-regs'. Use command 'set remotecache' instead of 'set circular-trace-buffer'. --- gdb/testsuite/gdb.mi/mi-cmd-param-changed.exp | 12 +++++------- 1 files changed, 5 insertions(+), 7 deletions(-) diff --git a/gdb/testsuite/gdb.mi/mi-cmd-param-changed.exp b/gdb/testsuite/gdb.mi/mi-cmd-param-changed.exp index 8c2195c..7786f90 100644 --- a/gdb/testsuite/gdb.mi/mi-cmd-param-changed.exp +++ b/gdb/testsuite/gdb.mi/mi-cmd-param-changed.exp @@ -52,7 +52,7 @@ proc test_command_param_changed { } { with_test_prefix "cmd param" { "\"set scheduler-locking stepr\" no event" - foreach command { "circular-trace-buffer" "check type" } { + foreach command { "remotecache" "check type" } { # The default value of each command option may be different, so we first # set it to 'off', and this may or may not trigger MI notification. @@ -81,12 +81,10 @@ proc test_command_param_changed { } { with_test_prefix "cmd param" { } # No notification is emitted for 'maint set' commands. - foreach command { "profile" "show-debug-regs" } { - foreach boolean_opt { "on" "off" } { - mi_gdb_test "maint set ${command} ${boolean_opt}" \ - "\\&\"maint set ${command} ${boolean_opt}\\\\n\"\r\n\\^done" \ - "\"maint set ${command} ${boolean_opt}\"" - } + foreach boolean_opt { "on" "off" } { + mi_gdb_test "maint set profile ${boolean_opt}" \ + "\\&\"maint set profile ${boolean_opt}\\\\n\"\r\n\\^done" \ + "\"maint set profile ${boolean_opt}\"" } # Full command parameters are included in the notification when a -- 1.7.7.6