Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Yao Qi <yao@codesourcery.com>
To: <gdb-patches@sourceware.org>
Subject: [PATCH 4/6] Remove 'substruct_type' and 'subfieldno'.
Date: Thu, 01 Nov 2012 07:47:00 -0000	[thread overview]
Message-ID: <1351756007-18242-5-git-send-email-yao@codesourcery.com> (raw)
In-Reply-To: <1351756007-18242-1-git-send-email-yao@codesourcery.com>

gdb:

2012-11-01  Yao Qi  <yao@codesourcery.com>

	* eval.c (evaluate_struct_tuple): Replace 'substruct_type' with
	'struct_type'.  Replace 'subfieldno' with 'fieldno'.
---
 gdb/eval.c |    7 ++-----
 1 files changed, 2 insertions(+), 5 deletions(-)

diff --git a/gdb/eval.c b/gdb/eval.c
index 3eb4896..62b26a9 100644
--- a/gdb/eval.c
+++ b/gdb/eval.c
@@ -287,10 +287,8 @@ evaluate_struct_tuple (struct value *struct_val,
 		       int *pos, enum noside noside, int nargs)
 {
   struct type *struct_type = check_typedef (value_type (struct_val));
-  struct type *substruct_type = struct_type;
   struct type *field_type;
   int fieldno = -1;
-  int subfieldno = -1;
 
   while (--nargs >= 0)
     {
@@ -306,7 +304,6 @@ evaluate_struct_tuple (struct value *struct_val,
 			 && field_is_static (&TYPE_FIELD (struct_type,
 							  fieldno)))
 		    fieldno++;
-		  subfieldno = fieldno;
 		  if (fieldno >= TYPE_NFIELDS (struct_type))
 		    error (_("too many initializers"));
 		  field_type = TYPE_FIELD_TYPE (struct_type, fieldno);
@@ -325,7 +322,7 @@ evaluate_struct_tuple (struct value *struct_val,
 	     subfieldno is the index of the actual real (named inner) field
 	     in substruct_type.  */
 
-	  field_type = TYPE_FIELD_TYPE (substruct_type, subfieldno);
+	  field_type = TYPE_FIELD_TYPE (struct_type, fieldno);
 	  if (val == 0)
 	    val = evaluate_subexp (field_type, exp, pos, noside);
 
@@ -335,7 +332,7 @@ evaluate_struct_tuple (struct value *struct_val,
 	  if (value_type (val) != field_type)
 	    val = value_cast (field_type, val);
 
-	  bitsize = TYPE_FIELD_BITSIZE (substruct_type, subfieldno);
+	  bitsize = TYPE_FIELD_BITSIZE (struct_type, fieldno);
 	  bitpos = TYPE_FIELD_BITPOS (struct_type, fieldno);
 	  addr = value_contents_writeable (struct_val) + bitpos / 8;
 	  if (bitsize)
-- 
1.7.7.6


  parent reply	other threads:[~2012-11-01  7:47 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-01  7:47 [PATCH 0/6] Remove unused operator OP_LABELED Yao Qi
2012-11-01  7:47 ` [PATCH 1/6] Remove OP_LABELED Yao Qi
2012-11-01 15:41   ` Tom Tromey
2012-11-02 16:43   ` Pedro Alves
2012-11-02 16:49     ` Tom Tromey
2012-11-02 16:51       ` Pedro Alves
2012-11-02 17:09         ` Tom Tromey
2012-11-02 17:25           ` Pedro Alves
2012-11-01  7:47 ` [PATCH 3/6] Remove 'variantno' Yao Qi
2012-11-01 15:44   ` Tom Tromey
2012-11-01  7:47 ` [PATCH 5/6] Indentation Yao Qi
2012-11-01 15:45   ` Tom Tromey
2012-11-01  7:47 ` Yao Qi [this message]
2012-11-01 15:44   ` [PATCH 4/6] Remove 'substruct_type' and 'subfieldno' Tom Tromey
2012-11-01  7:47 ` [PATCH 6/6] Test nested struct assign Yao Qi
2012-11-01 15:47   ` Tom Tromey
2012-11-01  7:47 ` [PATCH 2/6] Update comment of evaluate_struct_tuple Yao Qi
2012-11-01 15:42   ` Tom Tromey
2012-11-01 15:47 ` [PATCH 0/6] Remove unused operator OP_LABELED Tom Tromey
2012-11-02  0:20   ` [committed]: " Yao Qi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1351756007-18242-5-git-send-email-yao@codesourcery.com \
    --to=yao@codesourcery.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox