Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Yao Qi <yao@codesourcery.com>
To: <gdb-patches@sourceware.org>
Subject: [PATCH 3/6] Remove 'variantno'.
Date: Thu, 01 Nov 2012 07:47:00 -0000	[thread overview]
Message-ID: <1351756007-18242-4-git-send-email-yao@codesourcery.com> (raw)
In-Reply-To: <1351756007-18242-1-git-send-email-yao@codesourcery.com>

As local variable 'variantno' becomens a constant -1, some code can be
removed.

gdb:

2012-11-01  Yao Qi  <yao@codesourcery.com>

	* eval.c (evaluate_struct_tuple): Remove local variable
	'variantno' and related code.
---
 gdb/eval.c |   14 --------------
 1 files changed, 0 insertions(+), 14 deletions(-)

diff --git a/gdb/eval.c b/gdb/eval.c
index 681012b..3eb4896 100644
--- a/gdb/eval.c
+++ b/gdb/eval.c
@@ -290,7 +290,6 @@ evaluate_struct_tuple (struct value *struct_val,
   struct type *substruct_type = struct_type;
   struct type *field_type;
   int fieldno = -1;
-  int variantno = -1;
   int subfieldno = -1;
 
   while (--nargs >= 0)
@@ -300,17 +299,6 @@ evaluate_struct_tuple (struct value *struct_val,
       bfd_byte *addr;
 	{
 	    {
-	      /* Unlabelled tuple element - go to next field.  */
-	      if (variantno >= 0)
-		{
-		  subfieldno++;
-		  if (subfieldno >= TYPE_NFIELDS (substruct_type))
-		    {
-		      variantno = -1;
-		      substruct_type = struct_type;
-		    }
-		}
-	      if (variantno < 0)
 		{
 		  fieldno++;
 		  /* Skip static fields.  */
@@ -349,8 +337,6 @@ evaluate_struct_tuple (struct value *struct_val,
 
 	  bitsize = TYPE_FIELD_BITSIZE (substruct_type, subfieldno);
 	  bitpos = TYPE_FIELD_BITPOS (struct_type, fieldno);
-	  if (variantno >= 0)
-	    bitpos += TYPE_FIELD_BITPOS (substruct_type, subfieldno);
 	  addr = value_contents_writeable (struct_val) + bitpos / 8;
 	  if (bitsize)
 	    modify_field (struct_type, addr,
-- 
1.7.7.6


  parent reply	other threads:[~2012-11-01  7:47 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-01  7:47 [PATCH 0/6] Remove unused operator OP_LABELED Yao Qi
2012-11-01  7:47 ` [PATCH 2/6] Update comment of evaluate_struct_tuple Yao Qi
2012-11-01 15:42   ` Tom Tromey
2012-11-01  7:47 ` [PATCH 6/6] Test nested struct assign Yao Qi
2012-11-01 15:47   ` Tom Tromey
2012-11-01  7:47 ` [PATCH 4/6] Remove 'substruct_type' and 'subfieldno' Yao Qi
2012-11-01 15:44   ` Tom Tromey
2012-11-01  7:47 ` [PATCH 5/6] Indentation Yao Qi
2012-11-01 15:45   ` Tom Tromey
2012-11-01  7:47 ` Yao Qi [this message]
2012-11-01 15:44   ` [PATCH 3/6] Remove 'variantno' Tom Tromey
2012-11-01  7:47 ` [PATCH 1/6] Remove OP_LABELED Yao Qi
2012-11-01 15:41   ` Tom Tromey
2012-11-02 16:43   ` Pedro Alves
2012-11-02 16:49     ` Tom Tromey
2012-11-02 16:51       ` Pedro Alves
2012-11-02 17:09         ` Tom Tromey
2012-11-02 17:25           ` Pedro Alves
2012-11-01 15:47 ` [PATCH 0/6] Remove unused operator OP_LABELED Tom Tromey
2012-11-02  0:20   ` [committed]: " Yao Qi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1351756007-18242-4-git-send-email-yao@codesourcery.com \
    --to=yao@codesourcery.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox