Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Yao Qi <yao@codesourcery.com>
To: <gdb-patches@sourceware.org>
Subject: [2nd try, RFC 0/2] Fix 'set remote XXX-limit -1' and 'set listisize'
Date: Sun, 09 Sep 2012 03:23:00 -0000	[thread overview]
Message-ID: <1347160965-24089-1-git-send-email-yao@codesourcery.com> (raw)

Hi,
It was reported that my patch committed last month broke 'set remote
XXX-limit -1' by Khoo Yit Phang

  http://sourceware.org/ml/gdb-patches/2012-07/msg00702.html

and I proposed fix to this problem by adding a new type of 'var_type'
var_zuinteger_unlimited twice here,

  [RFC 0/3] New var_types var_zuinteger_unlimited
  http://sourceware.org/ml/gdb-patches/2012-08/msg00020.html

and

  [RFC 0/3] Get rid of var_integer in CLI
  http://sourceware.org/ml/gdb-patches/2012-08/msg00364.html

I feel that people are not convinced to add a new var_type
var_zuinteger_unlimited, so I decide to fix the problem in another way
(don't add new var_type).

Patch 1/2 adds the range check of command input, and patch 2/2 fixes
the inconsistency of the meaning of '0' and '-1' of 'listsize'.  I am
not sure it is a good idea to change the meaning of '0' and '-1' for
command 'set listsize' which has been used for many years, but it is
the best I can think of to fix the problem without adding new
var_type.  Comments are welcome.


             reply	other threads:[~2012-09-09  3:23 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-09  3:23 Yao Qi [this message]
2012-09-09  3:23 ` [PATCH 1/2] Check the range Yao Qi
2012-09-09  3:24 ` [PATCH 2/2] Update doc and test of 'set listsize' Yao Qi
2012-09-09 17:27   ` Eli Zaretskii
2012-09-14 18:55 ` [2nd try, RFC 0/2] Fix 'set remote XXX-limit -1' and 'set listisize' Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1347160965-24089-1-git-send-email-yao@codesourcery.com \
    --to=yao@codesourcery.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox