From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22910 invoked by alias); 9 Sep 2012 03:23:54 -0000 Received: (qmail 22901 invoked by uid 22791); 9 Sep 2012 03:23:52 -0000 X-SWARE-Spam-Status: No, hits=-3.6 required=5.0 tests=AWL,BAYES_00,FROM_12LTRDOM,KHOP_RCVD_UNTRUST,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL X-Spam-Check-By: sourceware.org Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sun, 09 Sep 2012 03:23:39 +0000 Received: from svr-orw-fem-01.mgc.mentorg.com ([147.34.98.93]) by relay1.mentorg.com with esmtp id 1TAY7X-0006iu-60 from Yao_Qi@mentor.com for gdb-patches@sourceware.org; Sat, 08 Sep 2012 20:23:39 -0700 Received: from SVR-ORW-FEM-04.mgc.mentorg.com ([147.34.97.41]) by svr-orw-fem-01.mgc.mentorg.com over TLS secured channel with Microsoft SMTPSVC(6.0.3790.4675); Sat, 8 Sep 2012 20:23:39 -0700 Received: from qiyao.dyndns.org.dyndns.org (147.34.91.1) by svr-orw-fem-04.mgc.mentorg.com (147.34.97.41) with Microsoft SMTP Server id 14.1.289.1; Sat, 8 Sep 2012 20:23:37 -0700 From: Yao Qi To: Subject: [2nd try, RFC 0/2] Fix 'set remote XXX-limit -1' and 'set listisize' Date: Sun, 09 Sep 2012 03:23:00 -0000 Message-ID: <1347160965-24089-1-git-send-email-yao@codesourcery.com> MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-09/txt/msg00089.txt.bz2 Hi, It was reported that my patch committed last month broke 'set remote XXX-limit -1' by Khoo Yit Phang http://sourceware.org/ml/gdb-patches/2012-07/msg00702.html and I proposed fix to this problem by adding a new type of 'var_type' var_zuinteger_unlimited twice here, [RFC 0/3] New var_types var_zuinteger_unlimited http://sourceware.org/ml/gdb-patches/2012-08/msg00020.html and [RFC 0/3] Get rid of var_integer in CLI http://sourceware.org/ml/gdb-patches/2012-08/msg00364.html I feel that people are not convinced to add a new var_type var_zuinteger_unlimited, so I decide to fix the problem in another way (don't add new var_type). Patch 1/2 adds the range check of command input, and patch 2/2 fixes the inconsistency of the meaning of '0' and '-1' of 'listsize'. I am not sure it is a good idea to change the meaning of '0' and '-1' for command 'set listsize' which has been used for many years, but it is the best I can think of to fix the problem without adding new var_type. Comments are welcome.