From: Yao Qi <yao@codesourcery.com>
To: <gdb-patches@sourceware.org>
Subject: [PATCH 3/3] use zuinteger_unlimited for heuristic-fence-post
Date: Wed, 01 Aug 2012 13:56:00 -0000 [thread overview]
Message-ID: <1343829334-3151-4-git-send-email-yao@codesourcery.com> (raw)
In-Reply-To: <1343829334-3151-1-git-send-email-yao@codesourcery.com>
Hi,
The comment here gives me a feeling that we should
convert this command to zuinteger_unlimited_cmd.
gdb:
2012-08-01 Yao Qi <yao@codesourcery.com>
* alpha-tdep.c (_initialize_alpha_tdep): Call
add_setshow_zuinteger_unlimited_cmd instead of
add_setshow_zinteger_cmd.
Remove comments.
* mips-tdep.c (_initialize_mips_tdep): Likewise.
---
gdb/alpha-tdep.c | 16 +++++++---------
gdb/mips-tdep.c | 16 +++++++---------
2 files changed, 14 insertions(+), 18 deletions(-)
diff --git a/gdb/alpha-tdep.c b/gdb/alpha-tdep.c
index 5d3affa..295bdec 100644
--- a/gdb/alpha-tdep.c
+++ b/gdb/alpha-tdep.c
@@ -1874,20 +1874,18 @@ _initialize_alpha_tdep (void)
/* Let the user set the fence post for heuristic_proc_start. */
- /* We really would like to have both "0" and "unlimited" work, but
- command.c doesn't deal with that. So make it a var_zinteger
- because the user can always use "999999" or some such for unlimited. */
/* We need to throw away the frame cache when we set this, since it
might change our ability to get backtraces. */
- add_setshow_zinteger_cmd ("heuristic-fence-post", class_support,
- &heuristic_fence_post, _("\
+ add_setshow_zuinteger_unlimited_cmd ("heuristic-fence-post", class_support,
+ &heuristic_fence_post, _("\
Set the distance searched for the start of a function."), _("\
Show the distance searched for the start of a function."), _("\
If you are debugging a stripped executable, GDB needs to search through the\n\
program for the start of a function. This command sets the distance of the\n\
search. The only need to set it is when debugging a stripped executable."),
- reinit_frame_cache_sfunc,
- NULL, /* FIXME: i18n: The distance searched for
- the start of a function is \"%d\". */
- &setlist, &showlist);
+ reinit_frame_cache_sfunc,
+ NULL, /* FIXME: i18n: The distance
+ searched for the start of a
+ function is \"%d\". */
+ &setlist, &showlist);
}
diff --git a/gdb/mips-tdep.c b/gdb/mips-tdep.c
index 0439989..32b5e12 100644
--- a/gdb/mips-tdep.c
+++ b/gdb/mips-tdep.c
@@ -8835,20 +8835,18 @@ and is updated automatically from ELF file flags if available."),
_("Show current use of MIPS floating-point coprocessor target."),
&showlist);
- /* We really would like to have both "0" and "unlimited" work, but
- command.c doesn't deal with that. So make it a var_zinteger
- because the user can always use "999999" or some such for unlimited. */
- add_setshow_zinteger_cmd ("heuristic-fence-post", class_support,
- &heuristic_fence_post, _("\
+ add_setshow_zuinteger_unlimited_cmd ("heuristic-fence-post", class_support,
+ &heuristic_fence_post, _("\
Set the distance searched for the start of a function."), _("\
Show the distance searched for the start of a function."), _("\
If you are debugging a stripped executable, GDB needs to search through the\n\
program for the start of a function. This command sets the distance of the\n\
search. The only need to set it is when debugging a stripped executable."),
- reinit_frame_cache_sfunc,
- NULL, /* FIXME: i18n: The distance searched for
- the start of a function is %s. */
- &setlist, &showlist);
+ reinit_frame_cache_sfunc,
+ NULL, /* FIXME: i18n: The distance
+ searched for the start of a
+ function is %s. */
+ &setlist, &showlist);
/* Allow the user to control whether the upper bits of 64-bit
addresses should be zeroed. */
--
1.7.7.6
next prev parent reply other threads:[~2012-08-01 13:56 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-18 12:52 [PATCH] Handle var_uinteger/var_zuinteger and case var_integer/var_zinteger together Yao Qi
2012-07-24 12:51 ` [committed]: " Yao Qi
2012-07-27 17:40 ` Khoo Yit Phang
2012-07-29 14:25 ` Yao Qi
2012-08-01 13:56 ` [RFC 0/3] New var_types var_zuinteger_unlimited Yao Qi
2012-08-01 13:56 ` [PATCH 2/3] use zuinteger_unlimited for some remote commands Yao Qi
2012-08-01 13:56 ` Yao Qi [this message]
2012-08-01 13:56 ` [PATCH 1/3] var_zuinteger_unlimited and 'set listsize' Yao Qi
2012-08-01 16:14 ` Eli Zaretskii
2012-08-02 8:34 ` Doug Evans
2012-08-02 12:53 ` Yao Qi
2012-08-13 15:28 ` [RFC 0/3] Get rid of var_integer in CLI Yao Qi
2012-08-13 15:28 ` [PATCH 3/3] comments update Yao Qi
2012-09-14 18:13 ` Tom Tromey
2012-08-13 15:28 ` [PATCH 2/3] var_integer -> var_zuinteger_unlimited Yao Qi
2012-08-13 17:54 ` Eli Zaretskii
2012-09-14 18:12 ` Tom Tromey
2012-09-17 8:43 ` [committed]: " Yao Qi
2012-08-13 15:28 ` [PATCH 1/3] var_integer -> var_uinteger Yao Qi
2012-08-23 18:20 ` dje
2012-08-24 6:56 ` Yao Qi
2012-08-24 17:06 ` dje
2012-08-27 10:10 ` Yao Qi
2012-08-27 22:14 ` dje
2012-08-28 14:09 ` [committed]: " Yao Qi
2013-03-25 22:55 ` Change "set history size" back to signed (Re: [committed]: [PATCH 1/3] var_integer -> var_uinteger) Pedro Alves
2013-03-26 16:48 ` Yao Qi
2013-03-26 17:48 ` Pedro Alves
2013-03-27 8:54 ` Yao Qi
2013-03-27 17:34 ` Pedro Alves
2012-08-22 14:30 ` [ping] : [RFC 0/3] Get rid of var_integer in CLI Yao Qi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1343829334-3151-4-git-send-email-yao@codesourcery.com \
--to=yao@codesourcery.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox