From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25122 invoked by alias); 1 Aug 2012 13:56:58 -0000 Received: (qmail 24983 invoked by uid 22791); 1 Aug 2012 13:56:55 -0000 X-SWARE-Spam-Status: No, hits=-4.4 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL X-Spam-Check-By: sourceware.org Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 01 Aug 2012 13:56:41 +0000 Received: from svr-orw-fem-01.mgc.mentorg.com ([147.34.98.93]) by relay1.mentorg.com with esmtp id 1SwZPl-0003Of-2B from Yao_Qi@mentor.com for gdb-patches@sourceware.org; Wed, 01 Aug 2012 06:56:41 -0700 Received: from SVR-ORW-FEM-02.mgc.mentorg.com ([147.34.96.206]) by svr-orw-fem-01.mgc.mentorg.com over TLS secured channel with Microsoft SMTPSVC(6.0.3790.4675); Wed, 1 Aug 2012 06:56:40 -0700 Received: from qiyao.dyndns.org.dyndns.org (147.34.91.1) by svr-orw-fem-02.mgc.mentorg.com (147.34.96.168) with Microsoft SMTP Server id 14.1.289.1; Wed, 1 Aug 2012 06:56:39 -0700 From: Yao Qi To: Subject: [PATCH 3/3] use zuinteger_unlimited for heuristic-fence-post Date: Wed, 01 Aug 2012 13:56:00 -0000 Message-ID: <1343829334-3151-4-git-send-email-yao@codesourcery.com> In-Reply-To: <1343829334-3151-1-git-send-email-yao@codesourcery.com> References: <7A6A55B4-0293-4AD6-AB1F-B3169F8ADCC1@cs.umd.edu> <1343829334-3151-1-git-send-email-yao@codesourcery.com> MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-08/txt/msg00023.txt.bz2 Hi, The comment here gives me a feeling that we should convert this command to zuinteger_unlimited_cmd. gdb: 2012-08-01 Yao Qi * alpha-tdep.c (_initialize_alpha_tdep): Call add_setshow_zuinteger_unlimited_cmd instead of add_setshow_zinteger_cmd. Remove comments. * mips-tdep.c (_initialize_mips_tdep): Likewise. --- gdb/alpha-tdep.c | 16 +++++++--------- gdb/mips-tdep.c | 16 +++++++--------- 2 files changed, 14 insertions(+), 18 deletions(-) diff --git a/gdb/alpha-tdep.c b/gdb/alpha-tdep.c index 5d3affa..295bdec 100644 --- a/gdb/alpha-tdep.c +++ b/gdb/alpha-tdep.c @@ -1874,20 +1874,18 @@ _initialize_alpha_tdep (void) /* Let the user set the fence post for heuristic_proc_start. */ - /* We really would like to have both "0" and "unlimited" work, but - command.c doesn't deal with that. So make it a var_zinteger - because the user can always use "999999" or some such for unlimited. */ /* We need to throw away the frame cache when we set this, since it might change our ability to get backtraces. */ - add_setshow_zinteger_cmd ("heuristic-fence-post", class_support, - &heuristic_fence_post, _("\ + add_setshow_zuinteger_unlimited_cmd ("heuristic-fence-post", class_support, + &heuristic_fence_post, _("\ Set the distance searched for the start of a function."), _("\ Show the distance searched for the start of a function."), _("\ If you are debugging a stripped executable, GDB needs to search through the\n\ program for the start of a function. This command sets the distance of the\n\ search. The only need to set it is when debugging a stripped executable."), - reinit_frame_cache_sfunc, - NULL, /* FIXME: i18n: The distance searched for - the start of a function is \"%d\". */ - &setlist, &showlist); + reinit_frame_cache_sfunc, + NULL, /* FIXME: i18n: The distance + searched for the start of a + function is \"%d\". */ + &setlist, &showlist); } diff --git a/gdb/mips-tdep.c b/gdb/mips-tdep.c index 0439989..32b5e12 100644 --- a/gdb/mips-tdep.c +++ b/gdb/mips-tdep.c @@ -8835,20 +8835,18 @@ and is updated automatically from ELF file flags if available."), _("Show current use of MIPS floating-point coprocessor target."), &showlist); - /* We really would like to have both "0" and "unlimited" work, but - command.c doesn't deal with that. So make it a var_zinteger - because the user can always use "999999" or some such for unlimited. */ - add_setshow_zinteger_cmd ("heuristic-fence-post", class_support, - &heuristic_fence_post, _("\ + add_setshow_zuinteger_unlimited_cmd ("heuristic-fence-post", class_support, + &heuristic_fence_post, _("\ Set the distance searched for the start of a function."), _("\ Show the distance searched for the start of a function."), _("\ If you are debugging a stripped executable, GDB needs to search through the\n\ program for the start of a function. This command sets the distance of the\n\ search. The only need to set it is when debugging a stripped executable."), - reinit_frame_cache_sfunc, - NULL, /* FIXME: i18n: The distance searched for - the start of a function is %s. */ - &setlist, &showlist); + reinit_frame_cache_sfunc, + NULL, /* FIXME: i18n: The distance + searched for the start of a + function is %s. */ + &setlist, &showlist); /* Allow the user to control whether the upper bits of 64-bit addresses should be zeroed. */ -- 1.7.7.6