[readline, djgpp] Check $build_os instead of $host_os in configure

[readline, djgpp] Check $build_os instead of $host_os in configure

[Yao Qi]

Hi,
When I configure gdb as '--host=i586-pc-msdosdjgpp --target=i586-pc-msdosdjgpp'
on x86-linux, I get following configure error in readline.

   readline/configure: line 6268: pwd.exe: command not found

Looks like the configure script should check $build_os instead of
$host_os.  This patch is to fix this problem.  Is it OK?

Note that I am not sure that AC_CANONICAL_BUILD is necessary here, because
after I add it in configure.in, the re-generated configure is nearly
unchanged.

readline:

	* readline/configure.in: Invoke AC_CANONICAL_BUILD.
	Change $host_os to $build_os.
	* readline/configure: Regenerated.
---
 readline/configure    |    3 ++-
 readline/configure.in |    3 ++-
 2 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/readline/configure b/readline/configure
index 0187311..09de45d 100755
--- a/readline/configure
+++ b/readline/configure
@@ -2285,6 +2285,7 @@ case $host_os in *\ *) host_os=`echo "$host_os" | sed 's/ /-/g'`;; esac
 
 
 
+
 opt_curses=no
 opt_purify=no
 
@@ -6264,7 +6265,7 @@ fi
 
 
 
-case "$host_os" in
+case "$build_os" in
 msdosdjgpp*)	BUILD_DIR=`pwd.exe` ;;	# to prevent //d/path/file
 *)		BUILD_DIR=`pwd` ;;
 esac
diff --git a/readline/configure.in b/readline/configure.in
index f09f4e5..b395af4 100644
--- a/readline/configure.in
+++ b/readline/configure.in
@@ -39,6 +39,7 @@ dnl update the value of RL_READLINE_VERSION in readline.h when this changes
 LIBVERSION=6.2
 
 AC_CANONICAL_HOST
+AC_CANONICAL_BUILD
 
 dnl configure defaults
 opt_curses=no
@@ -268,7 +269,7 @@ AC_SUBST(SHARED_TARGET)
 AC_SUBST(STATIC_INSTALL_TARGET)
 AC_SUBST(SHARED_INSTALL_TARGET)
 
-case "$host_os" in
+case "$build_os" in
 msdosdjgpp*)	BUILD_DIR=`pwd.exe` ;;	# to prevent //d/path/file
 *)		BUILD_DIR=`pwd` ;;
 esac
-- 
1.7.7.6

Re: [readline, djgpp] Check $build_os instead of $host_os in configure

[Pedro Alves]

On 08/01/2012 11:46 AM, Yao Qi wrote:
> Hi,
> When I configure gdb as '--host=i586-pc-msdosdjgpp --target=i586-pc-msdosdjgpp'
> on x86-linux, I get following configure error in readline.
> 
>    readline/configure: line 6268: pwd.exe: command not found
> 
> Looks like the configure script should check $build_os instead of
> $host_os.  This patch is to fix this problem.  Is it OK?

Thanks.

We'd like to avoid accumulating more local readline patches.
Can you submit this upstream first (bug-readline at gnu.org) ?
Once it gets accepted upstream, we can apply it locally as well.

> Note that I am not sure that AC_CANONICAL_BUILD is necessary here, because
> after I add it in configure.in, the re-generated configure is nearly
> unchanged.

-- 
Pedro Alves

Re: [readline, djgpp] Check $build_os instead of $host_os in configure

[Yao Qi]

On Wednesday, August 01, 2012 11:58:51 AM Pedro Alves wrote:
> We'd like to avoid accumulating more local readline patches.
> Can you submit this upstream first (bug-readline at gnu.org) ?
> Once it gets accepted upstream, we can apply it locally as well.

Sure.  I intended to submit this patch to readline upstream, but after looking 
for a dev mail list and source code in version control for a while on readline 
website, I am a little confused, and post patch here :)

'bug-readline at gnu.org' is the right place to go.  Thanks for your pointer.  
I'll post it there.

-- 
Yao (齐尧)

Re: [readline, djgpp] Check $build_os instead of $host_os in configure

[Jan Kratochvil]

Hi Yao,

On Wed, 01 Aug 2012 12:46:27 +0200, Yao Qi wrote:
>    readline/configure: line 6268: pwd.exe: command not found

you should post it first to:
	bug-readline@gnu.org


Thanks,
Jan

Re: [readline, djgpp] Check $build_os instead of $host_os in configure

[Eli Zaretskii]

> From: Yao Qi <yao@codesourcery.com>
> Date: Wed, 1 Aug 2012 18:46:27 +0800
> 
> Hi,
> When I configure gdb as '--host=i586-pc-msdosdjgpp --target=i586-pc-msdosdjgpp'
> on x86-linux, I get following configure error in readline.
> 
>    readline/configure: line 6268: pwd.exe: command not found
> 
> Looks like the configure script should check $build_os instead of
> $host_os.  This patch is to fix this problem.  Is it OK?

Fine with me, if you need my approval.