From: Yao Qi <yao@codesourcery.com>
To: <gdb-patches@sourceware.org>
Subject: [PATCH 1/4] New test for removing socket file in gdb.trace/strace.exp.
Date: Sat, 09 Jun 2012 12:47:00 -0000 [thread overview]
Message-ID: <1339246002-1987-2-git-send-email-yao@codesourcery.com> (raw)
In-Reply-To: <1339246002-1987-1-git-send-email-yao@codesourcery.com>
This new test can expose the problem that socket file is not removed
under some different situations,
We'll see three fails in both native and gdbserver testing,
FAIL: gdb.trace/strace.exp: remove_socket_after_quit: socket file removed
FAIL: gdb.trace/strace.exp: remove_socket_after_detach: socket file removed
FAIL: gdb.trace/strace.exp: remove_socket_after_continue: socket file removed
gdb/testsuite:
2012-06-09 Yao Qi <yao@codesourcery.com>
PR gdb/14161.
* gdb.trace/strace.exp (strace_remove_socket): New proc.
---
gdb/testsuite/gdb.trace/strace.exp | 69 ++++++++++++++++++++++++++++++++++++
1 files changed, 69 insertions(+), 0 deletions(-)
diff --git a/gdb/testsuite/gdb.trace/strace.exp b/gdb/testsuite/gdb.trace/strace.exp
index 51da92b..f141e9b 100644
--- a/gdb/testsuite/gdb.trace/strace.exp
+++ b/gdb/testsuite/gdb.trace/strace.exp
@@ -39,6 +39,68 @@ if { [gdb_compile $srcdir/$subdir/$srcfile $binfile executable $additional_flags
return -1
}
+# Test socket file is removed when GDB quit, detach or resume inferior until it
+# exits.
+
+proc strace_remove_socket { action } {
+ with_test_prefix "remove_socket_after_${action}" {
+
+ global executable
+ global gdb_prompt
+
+ # Restart with a fresh gdb.
+ clean_restart $executable
+ if ![runto_main] {
+ fail "Can't run to main"
+ return -1
+ }
+
+ # List the markers in program.
+ gdb_test "info static-tracepoint-markers" \
+ ".*ust/bar\[\t \]+n\[\t \]+.*ust/bar2\[\t \]+n\[\t \]+.*"
+
+ set pid ""
+ set test "collect pid"
+ gdb_test_multiple "info inferiors" $test {
+ -re "process (\[-0-9a-fx\]+) \[^\n\]*\n.*${gdb_prompt} $" {
+ set pid $expect_out(1,string)
+ pass $test
+ }
+ -re ".*${gdb_prompt} $" {
+ fail $test
+ }
+ }
+
+ set test "socket file exists"
+ set socket_file "/tmp/gdb_ust${pid}"
+ if { [file exists $socket_file] } {
+ pass $test
+ } else {
+ fail $test
+ }
+
+ send_gdb "${action}\n"
+ gdb_expect {
+ -re "A debugging session is active.\r\n.*\r\nQuit anyway\\? \\(y or n\\) $" {
+ send_gdb "y\n"
+ }
+ -re "Detaching .*, process .*$" {
+ }
+ -re "Continuing.*$" {
+ }
+ }
+
+ sleep 2
+
+ set test "socket file removed"
+ if { [file exists $socket_file] } {
+ fail $test
+ } else {
+ pass $test
+ }
+
+}}
+
proc strace_info_marker { } { with_test_prefix "info_marker" {
global executable
global gdb_prompt
@@ -253,6 +315,9 @@ if ![runto_main] {
if { ![is_remote target]
&& ([istarget "x86_64-*-linux*"] || [istarget "i\[34567\]86-*-linux*"]) } {
strace_info_marker
+ strace_remove_socket "quit"
+ strace_remove_socket "detach"
+ strace_remove_socket "continue"
return
}
@@ -263,6 +328,10 @@ if { ![gdb_target_supports_trace] } then {
gdb_load_shlibs $libipa
+strace_remove_socket "quit"
+strace_remove_socket "detach"
+strace_remove_socket "continue"
+
strace_info_marker
strace_probe_marker
--
1.7.0.4
next prev parent reply other threads:[~2012-06-09 12:47 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-09 12:47 [PATCH 0/4] PR14161: a partial fix Yao Qi
2012-06-09 12:47 ` [PATCH 4/4] gdb: kfail for PR14161 Yao Qi
2012-06-12 16:21 ` Pedro Alves
2012-06-14 15:01 ` Yao Qi
2012-06-15 19:33 ` Pedro Alves
2012-06-20 13:55 ` Yao Qi
2012-06-09 12:47 ` [PATCH 3/4] New agent command 'kill' and used by gdbserver Yao Qi
2012-06-09 13:11 ` Eli Zaretskii
2012-06-12 16:14 ` Pedro Alves
2012-06-14 14:50 ` Yao Qi
2012-06-14 16:37 ` Eli Zaretskii
2012-06-15 19:25 ` Pedro Alves
2012-06-20 13:49 ` Yao Qi
2012-06-21 16:05 ` Pedro Alves
2012-06-09 12:47 ` Yao Qi [this message]
2012-06-12 14:51 ` [PATCH 1/4] New test for removing socket file in gdb.trace/strace.exp Pedro Alves
2012-06-14 14:39 ` Yao Qi
2012-06-15 19:00 ` Pedro Alves
2012-06-20 13:46 ` Yao Qi
2012-06-21 15:56 ` Pedro Alves
2012-06-27 3:55 ` Yao Qi
2012-06-09 12:47 ` [PATCH 2/4] Remove socket file at exit Yao Qi
2012-06-12 15:14 ` Pedro Alves
2012-06-14 14:44 ` Yao Qi
2012-06-15 19:02 ` Pedro Alves
2012-07-27 8:19 ` [committed] : [PATCH 0/4] PR14161: a partial fix Yao Qi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1339246002-1987-2-git-send-email-yao@codesourcery.com \
--to=yao@codesourcery.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox