From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6326 invoked by alias); 9 Jun 2012 12:47:05 -0000 Received: (qmail 6228 invoked by uid 22791); 9 Jun 2012 12:47:04 -0000 X-SWARE-Spam-Status: No, hits=-3.3 required=5.0 tests=AWL,BAYES_00,FROM_12LTRDOM,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL X-Spam-Check-By: sourceware.org Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 09 Jun 2012 12:46:51 +0000 Received: from svr-orw-exc-10.mgc.mentorg.com ([147.34.98.58]) by relay1.mentorg.com with esmtp id 1SdL46-0005Ls-PI from Yao_Qi@mentor.com for gdb-patches@sourceware.org; Sat, 09 Jun 2012 05:46:50 -0700 Received: from SVR-ORW-FEM-02.mgc.mentorg.com ([147.34.96.206]) by SVR-ORW-EXC-10.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.4675); Sat, 9 Jun 2012 05:46:18 -0700 Received: from localhost.localdomain (147.34.91.1) by svr-orw-fem-02.mgc.mentorg.com (147.34.96.168) with Microsoft SMTP Server id 14.1.289.1; Sat, 9 Jun 2012 05:46:49 -0700 From: Yao Qi To: Subject: [PATCH 1/4] New test for removing socket file in gdb.trace/strace.exp. Date: Sat, 09 Jun 2012 12:47:00 -0000 Message-ID: <1339246002-1987-2-git-send-email-yao@codesourcery.com> In-Reply-To: <1339246002-1987-1-git-send-email-yao@codesourcery.com> References: <1339246002-1987-1-git-send-email-yao@codesourcery.com> MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-06/txt/msg00256.txt.bz2 This new test can expose the problem that socket file is not removed under some different situations, We'll see three fails in both native and gdbserver testing, FAIL: gdb.trace/strace.exp: remove_socket_after_quit: socket file removed FAIL: gdb.trace/strace.exp: remove_socket_after_detach: socket file removed FAIL: gdb.trace/strace.exp: remove_socket_after_continue: socket file removed gdb/testsuite: 2012-06-09 Yao Qi PR gdb/14161. * gdb.trace/strace.exp (strace_remove_socket): New proc. --- gdb/testsuite/gdb.trace/strace.exp | 69 ++++++++++++++++++++++++++++++++++++ 1 files changed, 69 insertions(+), 0 deletions(-) diff --git a/gdb/testsuite/gdb.trace/strace.exp b/gdb/testsuite/gdb.trace/strace.exp index 51da92b..f141e9b 100644 --- a/gdb/testsuite/gdb.trace/strace.exp +++ b/gdb/testsuite/gdb.trace/strace.exp @@ -39,6 +39,68 @@ if { [gdb_compile $srcdir/$subdir/$srcfile $binfile executable $additional_flags return -1 } +# Test socket file is removed when GDB quit, detach or resume inferior until it +# exits. + +proc strace_remove_socket { action } { + with_test_prefix "remove_socket_after_${action}" { + + global executable + global gdb_prompt + + # Restart with a fresh gdb. + clean_restart $executable + if ![runto_main] { + fail "Can't run to main" + return -1 + } + + # List the markers in program. + gdb_test "info static-tracepoint-markers" \ + ".*ust/bar\[\t \]+n\[\t \]+.*ust/bar2\[\t \]+n\[\t \]+.*" + + set pid "" + set test "collect pid" + gdb_test_multiple "info inferiors" $test { + -re "process (\[-0-9a-fx\]+) \[^\n\]*\n.*${gdb_prompt} $" { + set pid $expect_out(1,string) + pass $test + } + -re ".*${gdb_prompt} $" { + fail $test + } + } + + set test "socket file exists" + set socket_file "/tmp/gdb_ust${pid}" + if { [file exists $socket_file] } { + pass $test + } else { + fail $test + } + + send_gdb "${action}\n" + gdb_expect { + -re "A debugging session is active.\r\n.*\r\nQuit anyway\\? \\(y or n\\) $" { + send_gdb "y\n" + } + -re "Detaching .*, process .*$" { + } + -re "Continuing.*$" { + } + } + + sleep 2 + + set test "socket file removed" + if { [file exists $socket_file] } { + fail $test + } else { + pass $test + } + +}} + proc strace_info_marker { } { with_test_prefix "info_marker" { global executable global gdb_prompt @@ -253,6 +315,9 @@ if ![runto_main] { if { ![is_remote target] && ([istarget "x86_64-*-linux*"] || [istarget "i\[34567\]86-*-linux*"]) } { strace_info_marker + strace_remove_socket "quit" + strace_remove_socket "detach" + strace_remove_socket "continue" return } @@ -263,6 +328,10 @@ if { ![gdb_target_supports_trace] } then { gdb_load_shlibs $libipa +strace_remove_socket "quit" +strace_remove_socket "detach" +strace_remove_socket "continue" + strace_info_marker strace_probe_marker -- 1.7.0.4