* [commit] Document ui_out_field_core_addr.
@ 2011-07-04 18:56 Thiago Jung Bauermann
2011-07-05 16:27 ` Tom Tromey
0 siblings, 1 reply; 4+ messages in thread
From: Thiago Jung Bauermann @ 2011-07-04 18:56 UTC (permalink / raw)
To: gdb-patches ml
Hi,
$SUBJECT.
--
[]'s
Thiago Jung Bauermann
IBM Linux Technology Center
2011-07-04 Thiago Jung Bauermann <bauerman@br.ibm.com>
* ui-out.c (ui_out_field_core_addr): Mention that the function
description is in the header file.
* ui-out.h (ui_out_field_core_addr): Document function.
diff --git a/gdb/ui-out.c b/gdb/ui-out.c
index a2abf57..0b4ef54 100644
--- a/gdb/ui-out.c
+++ b/gdb/ui-out.c
@@ -486,6 +486,8 @@ ui_out_field_fmt_int (struct ui_out *uiout,
uo_field_int (uiout, fldno, input_width, input_align, fldname, value);
}
+/* Documented in ui-out.h. */
+
void
ui_out_field_core_addr (struct ui_out *uiout,
const char *fldname,
diff --git a/gdb/ui-out.h b/gdb/ui-out.h
index 5265902..244a145 100644
--- a/gdb/ui-out.h
+++ b/gdb/ui-out.h
@@ -113,6 +113,8 @@ extern void ui_out_field_fmt_int (struct ui_out *uiout, int width,
enum ui_align align, const char *fldname,
int value);
+/* Output a field containing an addresses. */
+
extern void ui_out_field_core_addr (struct ui_out *uiout, const char *fldname,
struct gdbarch *gdbarch, CORE_ADDR address);
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [commit] Document ui_out_field_core_addr.
2011-07-04 18:56 [commit] Document ui_out_field_core_addr Thiago Jung Bauermann
@ 2011-07-05 16:27 ` Tom Tromey
2011-07-05 19:18 ` Thiago Jung Bauermann
0 siblings, 1 reply; 4+ messages in thread
From: Tom Tromey @ 2011-07-05 16:27 UTC (permalink / raw)
To: Thiago Jung Bauermann; +Cc: gdb-patches ml
>>>>> "Thiago" == Thiago Jung Bauermann <bauerman@br.ibm.com> writes:
Thiago> 2011-07-04 Thiago Jung Bauermann <bauerman@br.ibm.com>
Thiago> * ui-out.c (ui_out_field_core_addr): Mention that the function
Thiago> description is in the header file.
Thiago> * ui-out.h (ui_out_field_core_addr): Document function.
Thiago> +/* Output a field containing an addresses. */
s/addresses/address/
Ok with that change.
Thanks for doing this.
Tom
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [commit] Document ui_out_field_core_addr.
2011-07-05 16:27 ` Tom Tromey
@ 2011-07-05 19:18 ` Thiago Jung Bauermann
2011-07-05 20:21 ` Tom Tromey
0 siblings, 1 reply; 4+ messages in thread
From: Thiago Jung Bauermann @ 2011-07-05 19:18 UTC (permalink / raw)
To: Tom Tromey; +Cc: gdb-patches ml
On Tue, 2011-07-05 at 10:26 -0600, Tom Tromey wrote:
> >>>>> "Thiago" == Thiago Jung Bauermann <bauerman@br.ibm.com> writes:
>
> Thiago> 2011-07-04 Thiago Jung Bauermann <bauerman@br.ibm.com>
> Thiago> * ui-out.c (ui_out_field_core_addr): Mention that the function
> Thiago> description is in the header file.
> Thiago> * ui-out.h (ui_out_field_core_addr): Document function.
>
> Thiago> +/* Output a field containing an addresses. */
>
> s/addresses/address/
>
> Ok with that change.
I had already committed the patch under the obvious rule. Here's the
patch I just committed.
--
[]'s
Thiago Jung Bauermann
IBM Linux Technology Center
2011-07-05 Thiago Jung Bauermann <bauerman@br.ibm.com>
* ui-out.h (ui_out_field_core_addr): Fix typo in comment.
diff --git a/gdb/ui-out.h b/gdb/ui-out.h
index ee6d98f..b0fddd8 100644
--- a/gdb/ui-out.h
+++ b/gdb/ui-out.h
@@ -113,7 +113,7 @@ extern void ui_out_field_fmt_int (struct ui_out *uiout, int width,
enum ui_align align, const char *fldname,
int value);
-/* Output a field containing an addresses. */
+/* Output a field containing an address. */
extern void ui_out_field_core_addr (struct ui_out *uiout, const char *fldname,
struct gdbarch *gdbarch, CORE_ADDR address);
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [commit] Document ui_out_field_core_addr.
2011-07-05 19:18 ` Thiago Jung Bauermann
@ 2011-07-05 20:21 ` Tom Tromey
0 siblings, 0 replies; 4+ messages in thread
From: Tom Tromey @ 2011-07-05 20:21 UTC (permalink / raw)
To: Thiago Jung Bauermann; +Cc: gdb-patches ml
Thiago> I had already committed the patch under the obvious rule.
Yeah, I realized that later. No worries.
Thiago> Here's the patch I just committed.
Thanks.
Tom
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2011-07-05 20:01 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-07-04 18:56 [commit] Document ui_out_field_core_addr Thiago Jung Bauermann
2011-07-05 16:27 ` Tom Tromey
2011-07-05 19:18 ` Thiago Jung Bauermann
2011-07-05 20:21 ` Tom Tromey
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox