From: Paul Bolle <pebolle@tiscali.nl>
To: gdb-patches@sourceware.org
Subject: Re: [PATCH] win32: Lookup symbols in the EA Table by ordinal
Date: Wed, 15 Jun 2011 08:14:00 -0000 [thread overview]
Message-ID: <1308125627.2166.9.camel@t41.thuisdomein> (raw)
In-Reply-To: <20110613183850.GA25400@ednor.casa.cgf.cx>
On Mon, 2011-06-13 at 14:38 -0400, Christopher Faylor wrote:
> This looks ok except for the unneeded reordering of the function. I didn't see
> any reason to move ordbase or expdata.
0) Thanks for the review.
1) Moving ordbase and exp_funcbase was mainly a nitpick (which wouldn't
justify a separate patch): I prefer file parsing code to match the
structure of the file format it parses (wherever that is feasible). And
here the code is jumping around the PE format for no apparent reason.
Paul Bolle
prev parent reply other threads:[~2011-06-15 8:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-12 11:57 Paul Bolle
2011-06-13 18:39 ` Christopher Faylor
2011-06-15 8:14 ` Paul Bolle [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1308125627.2166.9.camel@t41.thuisdomein \
--to=pebolle@tiscali.nl \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox