From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1023 invoked by alias); 15 Jun 2011 08:14:14 -0000 Received: (qmail 606 invoked by uid 22791); 15 Jun 2011 08:14:12 -0000 X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,T_RP_MATCHES_RCVD,T_TO_NO_BRKTS_FREEMAIL X-Spam-Check-By: sourceware.org Received: from smtp-out1.tiscali.nl (HELO smtp-out1.tiscali.nl) (195.241.79.176) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 15 Jun 2011 08:13:50 +0000 Received: from [212.123.169.34] (helo=[192.168.1.105]) by smtp-out1.tiscali.nl with esmtp (Exim) (envelope-from ) id 1QWlET-0003lN-Ig for gdb-patches@sourceware.org; Wed, 15 Jun 2011 10:13:49 +0200 Subject: Re: [PATCH] win32: Lookup symbols in the EA Table by ordinal From: Paul Bolle To: gdb-patches@sourceware.org Date: Wed, 15 Jun 2011 08:14:00 -0000 In-Reply-To: <20110613183850.GA25400@ednor.casa.cgf.cx> References: <1307879815.1831.0.camel@t41.thuisdomein> <20110613183850.GA25400@ednor.casa.cgf.cx> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Message-ID: <1308125627.2166.9.camel@t41.thuisdomein> Mime-Version: 1.0 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-06/txt/msg00206.txt.bz2 On Mon, 2011-06-13 at 14:38 -0400, Christopher Faylor wrote: > This looks ok except for the unneeded reordering of the function. I didn't see > any reason to move ordbase or expdata. 0) Thanks for the review. 1) Moving ordbase and exp_funcbase was mainly a nitpick (which wouldn't justify a separate patch): I prefer file parsing code to match the structure of the file format it parses (wherever that is feasible). And here the code is jumping around the PE format for no apparent reason. Paul Bolle