Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Thiago Jung Bauermann <bauerman@br.ibm.com>
To: Pedro Alves <pedro@codesourcery.com>
Cc: gdb-patches@sourceware.org, Joel Brobecker <brobecker@adacore.com>
Subject: Re: [patch][branch] Fix saving -location watchpoints.
Date: Wed, 13 Apr 2011 18:34:00 -0000	[thread overview]
Message-ID: <1302719656.3459.4.camel@hactar> (raw)
In-Reply-To: <201104121206.07705.pedro@codesourcery.com>

On Tue, 2011-04-12 at 12:06 +0100, Pedro Alves wrote:
> On Friday 08 April 2011 21:47:33, Thiago Jung Bauermann wrote:
> > watch_command_1 sets b->exp_string to "-location: foobar". When saving
> > breakpoints to a file, save_breakpoints will use b->exp_string to
> > construct a command line for recreating the watchpoint, and comes up
> > with the invalid command "watch -location: foobar". This patch simply
> > removes the colon from exp_string.
> > 
> > No regressions on i386-linux. Ok for HEAD and the branch?
> 
> This is okay with me.

Thanks! Committed to HEAD. Waiting for explicit OK for the branch.
-- 
[]'s
Thiago Jung Bauermann
IBM Linux Technology Center


  reply	other threads:[~2011-04-13 18:34 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-08 20:47 Thiago Jung Bauermann
2011-04-12 11:06 ` Pedro Alves
2011-04-13 18:34   ` Thiago Jung Bauermann [this message]
2011-04-14 11:52     ` Joel Brobecker
2011-04-15  4:20       ` Thiago Jung Bauermann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1302719656.3459.4.camel@hactar \
    --to=bauerman@br.ibm.com \
    --cc=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    --cc=pedro@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox