From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7084 invoked by alias); 13 Apr 2011 18:34:55 -0000 Received: (qmail 6991 invoked by uid 22791); 13 Apr 2011 18:34:55 -0000 X-SWARE-Spam-Status: No, hits=-1.5 required=5.0 tests=AWL,BAYES_00,SPF_SOFTFAIL,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from e34.co.us.ibm.com (HELO e34.co.us.ibm.com) (32.97.110.152) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 13 Apr 2011 18:34:51 +0000 Received: from d03relay05.boulder.ibm.com (d03relay05.boulder.ibm.com [9.17.195.107]) by e34.co.us.ibm.com (8.14.4/8.13.1) with ESMTP id p3DIMgD6016430 for ; Wed, 13 Apr 2011 12:22:42 -0600 Received: from d03av02.boulder.ibm.com (d03av02.boulder.ibm.com [9.17.195.168]) by d03relay05.boulder.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id p3DIYYNo096166 for ; Wed, 13 Apr 2011 12:34:34 -0600 Received: from d03av02.boulder.ibm.com (loopback [127.0.0.1]) by d03av02.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id p3DIYLJT004242 for ; Wed, 13 Apr 2011 12:34:24 -0600 Received: from [9.12.227.133] ([9.12.227.133]) by d03av02.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVin) with ESMTP id p3DIYJk5003974; Wed, 13 Apr 2011 12:34:20 -0600 Subject: Re: [patch][branch] Fix saving -location watchpoints. From: Thiago Jung Bauermann To: Pedro Alves Cc: gdb-patches@sourceware.org, Joel Brobecker In-Reply-To: <201104121206.07705.pedro@codesourcery.com> References: <1302295653.2074.15.camel@hactar> <201104121206.07705.pedro@codesourcery.com> Content-Type: text/plain; charset="UTF-8" Date: Wed, 13 Apr 2011 18:34:00 -0000 Message-ID: <1302719656.3459.4.camel@hactar> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-04/txt/msg00193.txt.bz2 On Tue, 2011-04-12 at 12:06 +0100, Pedro Alves wrote: > On Friday 08 April 2011 21:47:33, Thiago Jung Bauermann wrote: > > watch_command_1 sets b->exp_string to "-location: foobar". When saving > > breakpoints to a file, save_breakpoints will use b->exp_string to > > construct a command line for recreating the watchpoint, and comes up > > with the invalid command "watch -location: foobar". This patch simply > > removes the colon from exp_string. > > > > No regressions on i386-linux. Ok for HEAD and the branch? > > This is okay with me. Thanks! Committed to HEAD. Waiting for explicit OK for the branch. -- []'s Thiago Jung Bauermann IBM Linux Technology Center