From: Thiago Jung Bauermann <bauerman@br.ibm.com>
To: Tom Tromey <tromey@redhat.com>
Cc: gdb-patches ml <gdb-patches@sourceware.org>
Subject: Re: [RFA] Fix decode_indirect to use parse_to_comma_and_eval
Date: Fri, 04 Mar 2011 20:16:00 -0000 [thread overview]
Message-ID: <1299269319.3120.4.camel@hactar> (raw)
In-Reply-To: <m3r5aq6a6o.fsf@fleche.redhat.com>
On Tue, 2011-03-01 at 10:07 -0700, Tom Tromey wrote:
> >>>>> "Thiago" == Thiago Jung Bauermann <bauerman@br.ibm.com> writes:
>
> Thiago> This came up in the discussion about the ranged breakpoints patch. I
> Thiago> needed the break-range command to accept locations of the form *PC in a
> Thiago> string of the form "*PC_START, *PC_END" but couldn't call
> Thiago> parse_breakpoint_sals because decode_indirect (called by decode_line_1)
> Thiago> tried to read past the comma and got confused. Ulrich mentioned that it
> Thiago> should stop at the comma. This patch implements that.
>
> Usually I am opposed to incompatible changes, but this one seems fairly
> harmless to me. It seems unlikely that anybody ever uses a "," in an
> expression in a linespec.
>
> Thiago> No regressions on ppc-linux and ppc64-linux. Ok?
>
> If there are no objections by Friday, please go ahead.
Since there were no objections, I've just committed it. Thanks!
--
[]'s
Thiago Jung Bauermann
IBM Linux Technology Center
prev parent reply other threads:[~2011-03-04 20:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-23 20:47 Thiago Jung Bauermann
2011-03-01 17:08 ` Tom Tromey
2011-03-04 20:16 ` Thiago Jung Bauermann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1299269319.3120.4.camel@hactar \
--to=bauerman@br.ibm.com \
--cc=gdb-patches@sourceware.org \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox