From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29163 invoked by alias); 4 Mar 2011 20:16:23 -0000 Received: (qmail 29151 invoked by uid 22791); 4 Mar 2011 20:16:22 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from e24smtp04.br.ibm.com (HELO e24smtp04.br.ibm.com) (32.104.18.25) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 04 Mar 2011 20:16:17 +0000 Received: from /spool/local by e24smtp04.br.ibm.com with XMail ESMTP for from ; Fri, 4 Mar 2011 17:16:14 -0300 Received: from mailhub3.br.ibm.com ([9.18.232.110]) by e24smtp04.br.ibm.com ([10.172.0.140]) with XMail ESMTP; Fri, 4 Mar 2011 17:16:12 -0300 Received: from d24av02.br.ibm.com (d24av02.br.ibm.com [9.8.31.93]) by mailhub3.br.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id p24KGIQS2400468 for ; Fri, 4 Mar 2011 17:16:22 -0300 Received: from d24av02.br.ibm.com (loopback [127.0.0.1]) by d24av02.br.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id p24KG5Nq002349 for ; Fri, 4 Mar 2011 17:16:05 -0300 Received: from [9.12.229.99] ([9.12.229.99]) by d24av02.br.ibm.com (8.14.4/8.13.1/NCO v10.0 AVin) with ESMTP id p24KG3DX002306; Fri, 4 Mar 2011 17:16:04 -0300 Subject: Re: [RFA] Fix decode_indirect to use parse_to_comma_and_eval From: Thiago Jung Bauermann To: Tom Tromey Cc: gdb-patches ml In-Reply-To: References: <1298493740.3172.28.camel@hactar> Content-Type: text/plain; charset="UTF-8" Date: Fri, 04 Mar 2011 20:16:00 -0000 Message-ID: <1299269319.3120.4.camel@hactar> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit x-cbid: 11030420-8936-0000-0000-000000E861A7 X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-03/txt/msg00324.txt.bz2 On Tue, 2011-03-01 at 10:07 -0700, Tom Tromey wrote: > >>>>> "Thiago" == Thiago Jung Bauermann writes: > > Thiago> This came up in the discussion about the ranged breakpoints patch. I > Thiago> needed the break-range command to accept locations of the form *PC in a > Thiago> string of the form "*PC_START, *PC_END" but couldn't call > Thiago> parse_breakpoint_sals because decode_indirect (called by decode_line_1) > Thiago> tried to read past the comma and got confused. Ulrich mentioned that it > Thiago> should stop at the comma. This patch implements that. > > Usually I am opposed to incompatible changes, but this one seems fairly > harmless to me. It seems unlikely that anybody ever uses a "," in an > expression in a linespec. > > Thiago> No regressions on ppc-linux and ppc64-linux. Ok? > > If there are no objections by Friday, please go ahead. Since there were no objections, I've just committed it. Thanks! -- []'s Thiago Jung Bauermann IBM Linux Technology Center