Re: [RFA] Implement support for PowerPC BookE ranged watchpoints

[Thiago Jung Bauermann <bauerman@br.ibm.com>]

On Mon, 2011-01-10 at 23:36 +0000, Pedro Alves wrote:
> On Monday 10 January 2011 19:17:38, Thiago Jung Bauermann wrote:
> > +   the memory layout of a scalar type. E.g., an array or struct with only one
> 
> Double space.
> 
> > +static int
> > +resources_needed_watchpoint (const struct bp_location *bl)
> > +{
> > +    int length = bl->owner->exact? 1 : bl->length;
> > +
> > +    return target_region_ok_for_hw_watchpoint (bl->address, length);
> >  }
> 
> Indenting looks wrong.   Otherwise okay to commit.  Thanks for persevering!

Here's the patch I committed to fix the errors above.
-- 
[]'s
Thiago Jung Bauermann
IBM Linux Technology Center


2010-01-11  Thiago Jung Bauermann  <bauerman@br.ibm.com>

	* breakpoint.c (resources_needed_watchpoint): Fix indentation.
	* gdbtypes.c (is_scalar_type_recursive): Fix formatting.


Index: gdb.git/gdb/breakpoint.c
===================================================================
--- gdb.git.orig/gdb/breakpoint.c	2011-01-11 17:36:04.000000000 -0200
+++ gdb.git/gdb/breakpoint.c	2011-01-11 17:36:04.000000000 -0200
@@ -8278,9 +8278,9 @@ remove_watchpoint (struct bp_location *b
 static int
 resources_needed_watchpoint (const struct bp_location *bl)
 {
-    int length = bl->owner->exact? 1 : bl->length;
+  int length = bl->owner->exact? 1 : bl->length;
 
-    return target_region_ok_for_hw_watchpoint (bl->address, length);
+  return target_region_ok_for_hw_watchpoint (bl->address, length);
 }
 
 /* The breakpoint_ops structure to be used in hardware watchpoints.  */
Index: gdb.git/gdb/gdbtypes.c
===================================================================
--- gdb.git.orig/gdb/gdbtypes.c	2011-01-11 17:39:30.000000000 -0200
+++ gdb.git/gdb/gdbtypes.c	2011-01-11 17:39:38.000000000 -0200
@@ -1977,8 +1977,8 @@ is_scalar_type (struct type *type)
 }
 
 /* Return true if T is scalar, or a composite type which in practice has
-   the memory layout of a scalar type. E.g., an array or struct with only one
-   scalar element inside it, or a union with only scalar elements.  */
+   the memory layout of a scalar type.  E.g., an array or struct with only
+   one scalar element inside it, or a union with only scalar elements.  */
 
 int
 is_scalar_type_recursive (struct type *t)