From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6735 invoked by alias); 11 Jan 2011 19:48:49 -0000 Received: (qmail 6698 invoked by uid 22791); 11 Jan 2011 19:48:46 -0000 X-SWARE-Spam-Status: No, hits=-2.2 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from e24smtp03.br.ibm.com (HELO e24smtp03.br.ibm.com) (32.104.18.24) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 11 Jan 2011 19:48:41 +0000 Received: from mailhub1.br.ibm.com (mailhub1.br.ibm.com [9.18.232.109]) by e24smtp03.br.ibm.com (8.14.4/8.13.1) with ESMTP id p0BK4Kp1029192 for ; Tue, 11 Jan 2011 18:04:20 -0200 Received: from d24av03.br.ibm.com (d24av03.br.ibm.com [9.8.31.95]) by mailhub1.br.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id p0BJuGJL1036370 for ; Tue, 11 Jan 2011 17:56:16 -0200 Received: from d24av03.br.ibm.com (loopback [127.0.0.1]) by d24av03.br.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id p0BJmb8i023131 for ; Tue, 11 Jan 2011 17:48:38 -0200 Received: from [9.18.200.53] ([9.18.200.53]) by d24av03.br.ibm.com (8.14.4/8.13.1/NCO v10.0 AVin) with ESMTP id p0BJmbr2023127; Tue, 11 Jan 2011 17:48:37 -0200 Subject: Re: [RFA] Implement support for PowerPC BookE ranged watchpoints From: Thiago Jung Bauermann To: Pedro Alves Cc: gdb-patches@sourceware.org In-Reply-To: <201101102336.24435.pedro@codesourcery.com> References: <1294687058.3162.44.camel@hactar> <201101102336.24435.pedro@codesourcery.com> Content-Type: text/plain; charset="UTF-8" Date: Tue, 11 Jan 2011 21:09:00 -0000 Message-ID: <1294775316.4102.17.camel@hactar> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-01/txt/msg00232.txt.bz2 On Mon, 2011-01-10 at 23:36 +0000, Pedro Alves wrote: > On Monday 10 January 2011 19:17:38, Thiago Jung Bauermann wrote: > > + the memory layout of a scalar type. E.g., an array or struct with only one > > Double space. > > > +static int > > +resources_needed_watchpoint (const struct bp_location *bl) > > +{ > > + int length = bl->owner->exact? 1 : bl->length; > > + > > + return target_region_ok_for_hw_watchpoint (bl->address, length); > > } > > Indenting looks wrong. Otherwise okay to commit. Thanks for persevering! Here's the patch I committed to fix the errors above. -- []'s Thiago Jung Bauermann IBM Linux Technology Center 2010-01-11 Thiago Jung Bauermann * breakpoint.c (resources_needed_watchpoint): Fix indentation. * gdbtypes.c (is_scalar_type_recursive): Fix formatting. Index: gdb.git/gdb/breakpoint.c =================================================================== --- gdb.git.orig/gdb/breakpoint.c 2011-01-11 17:36:04.000000000 -0200 +++ gdb.git/gdb/breakpoint.c 2011-01-11 17:36:04.000000000 -0200 @@ -8278,9 +8278,9 @@ remove_watchpoint (struct bp_location *b static int resources_needed_watchpoint (const struct bp_location *bl) { - int length = bl->owner->exact? 1 : bl->length; + int length = bl->owner->exact? 1 : bl->length; - return target_region_ok_for_hw_watchpoint (bl->address, length); + return target_region_ok_for_hw_watchpoint (bl->address, length); } /* The breakpoint_ops structure to be used in hardware watchpoints. */ Index: gdb.git/gdb/gdbtypes.c =================================================================== --- gdb.git.orig/gdb/gdbtypes.c 2011-01-11 17:39:30.000000000 -0200 +++ gdb.git/gdb/gdbtypes.c 2011-01-11 17:39:38.000000000 -0200 @@ -1977,8 +1977,8 @@ is_scalar_type (struct type *type) } /* Return true if T is scalar, or a composite type which in practice has - the memory layout of a scalar type. E.g., an array or struct with only one - scalar element inside it, or a union with only scalar elements. */ + the memory layout of a scalar type. E.g., an array or struct with only + one scalar element inside it, or a union with only scalar elements. */ int is_scalar_type_recursive (struct type *t)