Re: [patch 2/3] Implement support for PowerPC BookE ranged watchpoints

[Thiago Jung Bauermann <bauerman@br.ibm.com>]

Hi Eli,

On Thu, 2010-12-23 at 21:04 +0200, Eli Zaretskii wrote:
> > From: Thiago Jung Bauermann <bauerman@br.ibm.com>
> > Cc: gdb-patches@sourceware.org, Jan Kratochvil <jan.kratochvil@redhat.com>,
> >         Joel Brobecker <brobecker@adacore.com>, Eli Zaretskii <eliz@gnu.org>
> > Date: Thu, 23 Dec 2010 16:49:42 -0200
> > 
> > +When running on PowerPC embedded processors @value{GDBN} automatically uses
>                                               ^
> Comma here, please.

Fixed.

> > +ranged hardware watchpoints unless the @code{exact-watchpoints} option is on,
>                               ^
> And here.

Fixed

> > +@item set powerpc exact-watchpoints
> > +@itemx show powerpc exact-watchpoints
> > +Allow @value{GDBN} to use only one debug register when watching a variable
> > +of scalar type, thus assuming that all acesses that modify that variable
> > +happen at its starting address.
> 
> I suggest a slight rewording of the last sentence:
> 
>   ... thus assuming that the variable is accessed through the address
>   of its first byte.
> 
> Is that wording accurate?  If it is, the patch for the manual is okay
> with those changes.

Yes, it is accurate. Adopted your wording. Thanks for the super-quick
review!
-- 
[]'s
Thiago Jung Bauermann
IBM Linux Technology Center