From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10906 invoked by alias); 23 Dec 2010 19:31:49 -0000 Received: (qmail 10897 invoked by uid 22791); 23 Dec 2010 19:31:49 -0000 X-SWARE-Spam-Status: No, hits=-2.3 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from e24smtp01.br.ibm.com (HELO e24smtp01.br.ibm.com) (32.104.18.85) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 23 Dec 2010 19:31:44 +0000 Received: from mailhub3.br.ibm.com (mailhub3.br.ibm.com [9.18.232.110]) by e24smtp01.br.ibm.com (8.14.4/8.13.1) with ESMTP id oBNJtBER008347 for ; Thu, 23 Dec 2010 17:55:11 -0200 Received: from d24av03.br.ibm.com (d24av03.br.ibm.com [9.8.31.95]) by mailhub3.br.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id oBNJd4x73031108 for ; Thu, 23 Dec 2010 17:39:04 -0200 Received: from d24av03.br.ibm.com (loopback [127.0.0.1]) by d24av03.br.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id oBNJVcDH018114 for ; Thu, 23 Dec 2010 17:31:39 -0200 Received: from [9.8.1.74] ([9.8.1.74]) by d24av03.br.ibm.com (8.14.4/8.13.1/NCO v10.0 AVin) with ESMTP id oBNJVc38018109; Thu, 23 Dec 2010 17:31:38 -0200 Subject: Re: [patch 2/3] Implement support for PowerPC BookE ranged watchpoints From: Thiago Jung Bauermann To: Eli Zaretskii Cc: pedro@codesourcery.com, gdb-patches@sourceware.org, jan.kratochvil@redhat.com, brobecker@adacore.com In-Reply-To: <83tyi4e2fk.fsf@gnu.org> References: <1290549100.3164.47.camel@hactar> <201011251731.58135.pedro@codesourcery.com> <1290806122.3009.37.camel@hactar> <201011271747.39053.pedro@codesourcery.com> <1293130182.14239.21.camel@hactar> <83tyi4e2fk.fsf@gnu.org> Content-Type: text/plain; charset="UTF-8" Date: Thu, 23 Dec 2010 20:17:00 -0000 Message-ID: <1293132697.14239.36.camel@hactar> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-12/txt/msg00443.txt.bz2 Hi Eli, On Thu, 2010-12-23 at 21:04 +0200, Eli Zaretskii wrote: > > From: Thiago Jung Bauermann > > Cc: gdb-patches@sourceware.org, Jan Kratochvil , > > Joel Brobecker , Eli Zaretskii > > Date: Thu, 23 Dec 2010 16:49:42 -0200 > > > > +When running on PowerPC embedded processors @value{GDBN} automatically uses > ^ > Comma here, please. Fixed. > > +ranged hardware watchpoints unless the @code{exact-watchpoints} option is on, > ^ > And here. Fixed > > +@item set powerpc exact-watchpoints > > +@itemx show powerpc exact-watchpoints > > +Allow @value{GDBN} to use only one debug register when watching a variable > > +of scalar type, thus assuming that all acesses that modify that variable > > +happen at its starting address. > > I suggest a slight rewording of the last sentence: > > ... thus assuming that the variable is accessed through the address > of its first byte. > > Is that wording accurate? If it is, the patch for the manual is okay > with those changes. Yes, it is accurate. Adopted your wording. Thanks for the super-quick review! -- []'s Thiago Jung Bauermann IBM Linux Technology Center