[PATCH] gdbserver: fix warning in nommu clone

[PATCH] gdbserver: fix warning in nommu clone

[Mike Frysinger]

Building gdbserver for nommu targets atm fails with:
	linux-low.c: In function 'linux_tracefork_child':
	linux-low.c:4151: error: pointer of type 'void *' used in arithmetic

So cast the void* to a char*.

Signed-off-by: Mike Frysinger <vapier@gentoo.org>

2010-11-16  Mike Frysinger  <vapier@gentoo.org>

	* linux-low.c (linux_tracefork_child): Add char* cast to arg.
---
 gdb/gdbserver/linux-low.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/gdb/gdbserver/linux-low.c b/gdb/gdbserver/linux-low.c
index 7c50251..a81a8dc 100644
--- a/gdb/gdbserver/linux-low.c
+++ b/gdb/gdbserver/linux-low.c
@@ -4148,7 +4148,7 @@ linux_tracefork_child (void *arg)
   __clone2 (linux_tracefork_grandchild, arg, STACK_SIZE,
 	    CLONE_VM | SIGCHLD, NULL);
 #else
-  clone (linux_tracefork_grandchild, arg + STACK_SIZE,
+  clone (linux_tracefork_grandchild, (char *)arg + STACK_SIZE,
 	 CLONE_VM | SIGCHLD, NULL);
 #endif
 
-- 
1.7.3.1

Re: [PATCH] gdbserver: fix warning in nommu clone

[Doug Evans]

On Mon, Nov 15, 2010 at 3:50 PM, Mike Frysinger <vapier@gentoo.org> wrote:
> Building gdbserver for nommu targets atm fails with:
>        linux-low.c: In function 'linux_tracefork_child':
>        linux-low.c:4151: error: pointer of type 'void *' used in arithmetic
>
> So cast the void* to a char*.
>
> Signed-off-by: Mike Frysinger <vapier@gentoo.org>
>
> 2010-11-16  Mike Frysinger  <vapier@gentoo.org>
>
>        * linux-low.c (linux_tracefork_child): Add char* cast to arg.
> ---
>  gdb/gdbserver/linux-low.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/gdb/gdbserver/linux-low.c b/gdb/gdbserver/linux-low.c
> index 7c50251..a81a8dc 100644
> --- a/gdb/gdbserver/linux-low.c
> +++ b/gdb/gdbserver/linux-low.c
> @@ -4148,7 +4148,7 @@ linux_tracefork_child (void *arg)
>   __clone2 (linux_tracefork_grandchild, arg, STACK_SIZE,
>            CLONE_VM | SIGCHLD, NULL);
>  #else
> -  clone (linux_tracefork_grandchild, arg + STACK_SIZE,
> +  clone (linux_tracefork_grandchild, (char *)arg + STACK_SIZE,
>         CLONE_VM | SIGCHLD, NULL);
>  #endif

Hi.
Nit: The convention is to put a space after (char *).
Ok with that change.

Re: [PATCH] gdbserver: fix warning in nommu clone

[Mike Frysinger]

[-- Attachment #1: Type: Text/Plain, Size: 499 bytes --]

On Monday, November 15, 2010 21:43:29 Doug Evans wrote:
> On Mon, Nov 15, 2010 at 3:50 PM, Mike Frysinger wrote:
> > Building gdbserver for nommu targets atm fails with:
> >        linux-low.c: In function 'linux_tracefork_child':
> >        linux-low.c:4151: error: pointer of type 'void *' used in
> > arithmetic
> > 
> > So cast the void* to a char*.
>
> Nit: The convention is to put a space after (char *).
> Ok with that change.

committed with that change then ... thanks
-mike

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]