From: Paul Hilfinger <HIlfinger@cs.berkeley.edu>
To: Tom Tromey <tromey@redhat.com>
Cc: Hilfinger@adacore.com, gdb-patches@sourceware.org
Subject: Re: [RFA] Extend hashed symbol dictionaries to work with Ada
Date: Thu, 07 Oct 2010 03:29:00 -0000 [thread overview]
Message-ID: <1286422120.16931.13.camel@syracuse.mckusick.com> (raw)
In-Reply-To: <m3wrpv0wob.fsf@fleche.redhat.com>
On Wed, 2010-10-06 at 16:43 -0600, Tom Tromey wrote:
> >>>>> "Paul" == Paul Hilfinger <hilfingr@syracuse.mckusick.com> writes:
> Paul> +full_match (const char* sym_name, const char* search_name)
>
> I noticed a few spots in the patch with "char* something" instead of
> "char *something".
>
Sorry; that notation is a personal quirk of mine (I consider * to be
part of the type; naturally, this means I have to avoid making the
'char* x, y' mistake). I sometimes forget to change it to the
wrong ... er ... standard way before submitting.
> Paul> + case '$': case '.': case 'X': case '(':
>
> I personally think it is clearer to put each case on a separate line,
> but I don't insist on it.
OK, since it appears that the only other places with more than one
case on a line are in arm-tdep.c and remote.c.
Thanks for looking at this.
Paul
next prev parent reply other threads:[~2010-10-07 3:29 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-05 8:20 Paul Hilfinger
2010-10-06 22:43 ` Tom Tromey
2010-10-06 22:53 ` Tom Tromey
2010-10-07 3:31 ` Paul Hilfinger
2010-10-07 7:17 ` [commit] " Paul Hilfinger
2010-10-07 8:44 ` [commit] Correct dict_hash to our most recent version Paul Hilfinger, :
2010-10-08 22:59 ` Tom Tromey
2010-10-07 3:29 ` Paul Hilfinger [this message]
2010-10-06 23:18 ` [RFA] Extend hashed symbol dictionaries to work with Ada Joel Brobecker
2010-10-06 23:59 ` Doug Evans
2010-10-07 6:29 ` Paul Hilfinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1286422120.16931.13.camel@syracuse.mckusick.com \
--to=hilfinger@cs.berkeley.edu \
--cc=Hilfinger@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox