From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23313 invoked by alias); 7 Oct 2010 03:29:28 -0000 Received: (qmail 23304 invoked by uid 22791); 7 Oct 2010 03:29:27 -0000 X-SWARE-Spam-Status: No, hits=-1.2 required=5.0 tests=AWL,BAYES_00,SPF_SOFTFAIL X-Spam-Check-By: sourceware.org Received: from syracuse.mckusick.com (HELO syracuse.mckusick.com) (64.81.247.46) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 07 Oct 2010 03:29:20 +0000 Received: from syracuse.mckusick.com (localhost [127.0.0.1]) by syracuse.mckusick.com (8.14.3/8.14.3/Debian-9.1ubuntu1) with ESMTP id o973SgXQ019159; Wed, 6 Oct 2010 20:28:42 -0700 Received: (from hilfingr@localhost) by syracuse.mckusick.com (8.14.3/8.14.3/Submit) id o973SfAn019157; Wed, 6 Oct 2010 20:28:41 -0700 Subject: Re: [RFA] Extend hashed symbol dictionaries to work with Ada From: Paul Hilfinger Reply-To: Hilfinger@adacore.com To: Tom Tromey Cc: Hilfinger@adacore.com, gdb-patches@sourceware.org In-Reply-To: References: <201010050820.o958Kf42002588@syracuse.mckusick.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Date: Thu, 07 Oct 2010 03:29:00 -0000 Message-ID: <1286422120.16931.13.camel@syracuse.mckusick.com> Mime-Version: 1.0 X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-10/txt/msg00110.txt.bz2 On Wed, 2010-10-06 at 16:43 -0600, Tom Tromey wrote: > >>>>> "Paul" =3D=3D Paul Hilfinger write= s: > Paul> +full_match (const char* sym_name, const char* search_name) >=20 > I noticed a few spots in the patch with "char* something" instead of > "char *something". >=20 Sorry; that notation is a personal quirk of mine (I consider * to be part of the type; naturally, this means I have to avoid making the 'char* x, y' mistake). I sometimes forget to change it to the wrong ... er ... standard way before submitting. > Paul> + case '$': case '.': case 'X': case '(': >=20 > I personally think it is clearer to put each case on a separate line, > but I don't insist on it. OK, since it appears that the only other places with more than one case on a line are in arm-tdep.c and remote.c. Thanks for looking at this. Paul