From: Paul Hilfinger <hilfingr@tully.CS.Berkeley.EDU>
To: Yao Qi <yao@codesourcery.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFA] Add test for use of "<block>::<variable>" syntax for locals in watch.
Date: Mon, 09 Jan 2012 20:02:00 -0000 [thread overview]
Message-ID: <12834.1326139342@tully.CS.Berkeley.EDU> (raw)
In-Reply-To: Your message of Mon, 09 Jan 2012 15:53:20 +0800. <4F0A9CF0.2040408@codesourcery.com>
Oops. Thanks for pointing out the typos.
> On 01/09/2012 03:26 PM, Paul Hilfinger wrote:
> > 2012-01-07 Paul Hilfinger <brobecker@adacore.com>
> >
>
> Your mail address is not correct :)
>
> I am not familiar with this test, but have some comments on format of
> changelog.
>
> > * gdb/testsuite/gdb.base/watchpoint.c (recurser): Initialize local_x.
> > (main) Repeat recurser call.
> ^^ Miss ":" here.
> > * gdb/testsuite/gdb.base/watchpoint.exp: Check that 'watch recurser::local_
> x' is
> > equivalent to 'local_x'.
>
> Each changelog entry is started from a tab. Since we have a ChangeLog
> file under gdb/testsuite, so we don't have to include "gdb/testuite" in
> file name. It can be like this,
>
> * gdb.base/watchpoint.c (recurser): Initialize local_x.
> (main): Repeat recurser call.
> * gdb.base/watchpoint.exp: Check that 'watch recurser::local_x' is
> equivalent to 'local_x'.
>
> --
> Yao (齐尧)
next prev parent reply other threads:[~2012-01-09 20:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-09 7:26 Paul Hilfinger
2012-01-09 7:53 ` Yao Qi
2012-01-09 20:02 ` Paul Hilfinger [this message]
2012-01-10 19:02 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=12834.1326139342@tully.CS.Berkeley.EDU \
--to=hilfingr@tully.cs.berkeley.edu \
--cc=Hilfinger@CS.Berkeley.EDU \
--cc=gdb-patches@sourceware.org \
--cc=yao@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox