From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-86882-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 11275 invoked by alias); 9 Jan 2012 20:02:41 -0000
Received: (qmail 11260 invoked by uid 22791); 9 Jan 2012 20:02:40 -0000
X-SWARE-Spam-Status: No, hits=-2.2 required=5.0	tests=AWL,BAYES_00,T_RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from tully.CS.Berkeley.EDU (HELO tully.CS.Berkeley.EDU) (128.32.153.206)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 09 Jan 2012 20:02:26 +0000
Received: from tully.CS.Berkeley.EDU (localhost [127.0.0.1])	by tully.CS.Berkeley.EDU (8.14.4+Sun/8.14.4) with ESMTP id q09K2MVp012835;	Mon, 9 Jan 2012 12:02:22 -0800 (PST)
To: Yao Qi <yao@codesourcery.com>
cc: gdb-patches@sourceware.org
Subject: Re: [RFA] Add test for use of "<block>::<variable>" syntax for locals in watch.
Reply-To: Hilfinger@CS.Berkeley.EDU
In-reply-to: Your message of Mon, 09 Jan 2012 15:53:20 +0800.             <4F0A9CF0.2040408@codesourcery.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Date: Mon, 09 Jan 2012 20:02:00 -0000
Message-ID: <12834.1326139342@tully.CS.Berkeley.EDU>
From: Paul Hilfinger <hilfingr@tully.CS.Berkeley.EDU>
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2012-01/txt/msg00279.txt.bz2


Oops.  Thanks for pointing out the typos.




> On 01/09/2012 03:26 PM, Paul Hilfinger wrote:
> > 2012-01-07  Paul Hilfinger  <brobecker@adacore.com>
> >=20
>=20
> Your mail address is not correct :)
>=20
> I am not familiar with this test, but have some comments on format of
> changelog.
>=20
> > * gdb/testsuite/gdb.base/watchpoint.c (recurser): Initialize local_x.
> >   (main) Repeat recurser call.
>           ^^ Miss ":" here.
> > * gdb/testsuite/gdb.base/watchpoint.exp: Check that 'watch recurser::lo=
cal_
> x' is
> >   equivalent to 'local_x'.
>=20
> Each changelog entry is started from a tab.  Since we have a ChangeLog
> file under gdb/testsuite, so we don't have to include "gdb/testuite" in
> file name.  It can be like this,
>=20
> 	* gdb.base/watchpoint.c (recurser): Initialize local_x.
> 	(main): Repeat recurser call.
> 	* gdb.base/watchpoint.exp: Check that 'watch recurser::local_x' is
> 	equivalent to 'local_x'.
>=20
> --=20
> Yao (=E9=BD=90=E5=B0=A7)