Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
* [PATCH] sim: fix fpu missing initializer warnings
@ 2010-04-23  1:54 Mike Frysinger
  2010-04-23 14:22 ` Joel Brobecker
  0 siblings, 1 reply; 2+ messages in thread
From: Mike Frysinger @ 2010-04-23  1:54 UTC (permalink / raw)
  To: gdb-patches

The current fpu code with externals enabled results in the warnings:
common/sim-fpu.c:2437: warning: missing initializer
common/sim-fpu.c:2437: warning: (near initialization for ‘sim_fpu_zero.sign’)
common/sim-fpu.c:2440: warning: missing initializer
common/sim-fpu.c:2440: warning: (near initialization for ‘sim_fpu_qnan.sign’)

So tweak the old style initializers to avoid these.

Signed-off-by: Mike Frysinger <vapier@gentoo.org>

2010-04-22  Mike Frysinger  <vapier@gentoo.org>

	* sim-fpu.c (sim_fpu_zero, sim_fpu_qnan): Add 0 initializers.
---
 sim/common/sim-fpu.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/sim/common/sim-fpu.c b/sim/common/sim-fpu.c
index 7af6170..6f1bad5 100644
--- a/sim/common/sim-fpu.c
+++ b/sim/common/sim-fpu.c
@@ -2425,10 +2425,10 @@ sim_fpu_gt (int *is,
 
 #if EXTERN_SIM_FPU_P
 const sim_fpu sim_fpu_zero = {
-  sim_fpu_class_zero,
+  sim_fpu_class_zero, 0, 0, 0
 };
 const sim_fpu sim_fpu_qnan = {
-  sim_fpu_class_qnan,
+  sim_fpu_class_qnan, 0, 0, 0
 };
 const sim_fpu sim_fpu_one = {
   sim_fpu_class_number, 0, IMPLICIT_1, 0
-- 
1.7.0.2


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] sim: fix fpu missing initializer warnings
  2010-04-23  1:54 [PATCH] sim: fix fpu missing initializer warnings Mike Frysinger
@ 2010-04-23 14:22 ` Joel Brobecker
  0 siblings, 0 replies; 2+ messages in thread
From: Joel Brobecker @ 2010-04-23 14:22 UTC (permalink / raw)
  To: Mike Frysinger; +Cc: gdb-patches

> 2010-04-22  Mike Frysinger  <vapier@gentoo.org>
> 
> 	* sim-fpu.c (sim_fpu_zero, sim_fpu_qnan): Add 0 initializers.

Looks good to me - please go ahead and check it in. (I think this type
of change can be considered obvious).

-- 
Joel


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2010-04-23 14:22 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-04-23  1:54 [PATCH] sim: fix fpu missing initializer warnings Mike Frysinger
2010-04-23 14:22 ` Joel Brobecker

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox