* [patch] nto gdbserver
@ 2010-04-20 17:16 Aleksandar Ristovski
2010-04-20 19:52 ` Pedro Alves
0 siblings, 1 reply; 6+ messages in thread
From: Aleksandar Ristovski @ 2010-04-20 17:16 UTC (permalink / raw)
To: gdb-patches
[-- Attachment #1: Type: text/plain, Size: 281 bytes --]
(I apologize if this message is duplicated)
Hello,
This patch fixes build breakage of gdbserver for Neutrino (QNX).
Thanks,
Aleksandar Ristovski
QNX Software Systems
Change Log:
2010-04-20 Aleksandar Ristovski <aristovski@qnx.com>
* nto-x86-low.c: Include server.h
[-- Attachment #2: nto-x86-low.c-20100419.patch --]
[-- Type: text/x-patch, Size: 547 bytes --]
Index: nto-x86-low.c
===================================================================
RCS file: /cvs/src/src/gdb/gdbserver/nto-x86-low.c,v
retrieving revision 1.2
diff -u -p -r1.2 nto-x86-low.c
--- nto-x86-low.c 1 Jan 2010 07:31:49 -0000 1.2
+++ nto-x86-low.c 19 Apr 2010 20:56:17 -0000
@@ -17,7 +17,7 @@
You should have received a copy of the GNU General Public License
along with this program. If not, see <http://www.gnu.org/licenses/>. */
-
+#include "server.h"
#include "nto-low.h"
#include "regdef.h"
#include "regcache.h"
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [patch] nto gdbserver
2010-04-20 17:16 [patch] nto gdbserver Aleksandar Ristovski
@ 2010-04-20 19:52 ` Pedro Alves
2010-04-20 20:24 ` Aleksandar Ristovski
0 siblings, 1 reply; 6+ messages in thread
From: Pedro Alves @ 2010-04-20 19:52 UTC (permalink / raw)
To: gdb-patches; +Cc: Aleksandar Ristovski
On Tuesday 20 April 2010 18:15:50, Aleksandar Ristovski wrote:
> 2010-04-20 Aleksandar Ristovski <aristovski@qnx.com>
> * nto-x86-low.c: Include server.h
>
This is okay. Though, I was going to say you also need to add $(server_h)
to nto-x86-low.o's dependency list in the corresponding Makefile.in
rule, but, I couldn't find any rule for this or any other nto file
at all. Would you like to fix it?
--
Pedro Alves
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [patch] nto gdbserver
2010-04-20 19:52 ` Pedro Alves
@ 2010-04-20 20:24 ` Aleksandar Ristovski
2010-04-20 20:43 ` Aleksandar Ristovski
0 siblings, 1 reply; 6+ messages in thread
From: Aleksandar Ristovski @ 2010-04-20 20:24 UTC (permalink / raw)
To: gdb-patches
On Tue, 2010-04-20 at 20:52 +0100, Pedro Alves wrote:
> On Tuesday 20 April 2010 18:15:50, Aleksandar Ristovski wrote:
> > 2010-04-20 Aleksandar Ristovski <aristovski@qnx.com>
> > * nto-x86-low.c: Include server.h
> >
>
> This is okay. Though, I was going to say you also need to add $(server_h)
> to nto-x86-low.o's dependency list in the corresponding Makefile.in
> rule, but, I couldn't find any rule for this or any other nto file
> at all. Would you like to fix it?
Yes, I will fix that and re-submit new patch with proper dependency
lists included, for approval.
Thank you,
--
Aleksandar Ristovski
QNX Software Systems
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [patch] nto gdbserver
2010-04-20 20:24 ` Aleksandar Ristovski
@ 2010-04-20 20:43 ` Aleksandar Ristovski
2010-04-20 20:49 ` Pedro Alves
0 siblings, 1 reply; 6+ messages in thread
From: Aleksandar Ristovski @ 2010-04-20 20:43 UTC (permalink / raw)
To: gdb-patches
[-- Attachment #1: Type: text/plain, Size: 354 bytes --]
New patch attached. I couldn't figure out the ordering of dependency
lists in gdbserver/Makefile.in ... so I just tried it put the lines in
as alphabetic order as possible.
ChangeLog:
* Makefile.in (nto_low_h nto-low.o nto-x86-low.o): New dependency lists.
* nto-x86-low.c: Include server.h
Thank you,
--
Aleksandar Ristovski
QNX Software Systems
[-- Attachment #2: nto-gdbserver-20100420.patch --]
[-- Type: text/x-patch, Size: 1599 bytes --]
Index: gdb/gdbserver/Makefile.in
===================================================================
RCS file: /cvs/src/src/gdb/gdbserver/Makefile.in,v
retrieving revision 1.85
diff -u -p -r1.85 Makefile.in
--- gdb/gdbserver/Makefile.in 9 Apr 2010 03:40:00 -0000 1.85
+++ gdb/gdbserver/Makefile.in 20 Apr 2010 20:32:12 -0000
@@ -274,6 +274,8 @@ server_h = $(srcdir)/server.h $(regcache
linux_low_h = $(srcdir)/linux-low.h
+nto_low_h = $(srcdir)/nto-low.h
+
event-loop.o: event-loop.c $(server_h)
hostio.o: hostio.c $(server_h)
hostio-errno.o: hostio-errno.c $(server_h)
@@ -319,6 +321,9 @@ linux-x86-low.o: linux-x86-low.c $(linux
$(gdb_proc_service_h) $(i386_low_h)
linux-xtensa-low.o: linux-xtensa-low.c xtensa-xtregs.c $(linux_low_h) $(server_h)
+nto-low.o: nto-low.c $(server_h) $(nto_low_h)
+nto-x86-low.o: nto-x86-low.c $(server_h) $(nto_low_h) $(regdef_h) $(regcache_h)
+
win32_low_h = $(srcdir)/win32-low.h
win32-low.o: win32-low.c $(win32_low_h) $(server_h) $(regdef_h) $(regcache_h)
Index: gdb/gdbserver/nto-x86-low.c
===================================================================
RCS file: /cvs/src/src/gdb/gdbserver/nto-x86-low.c,v
retrieving revision 1.2
diff -u -p -r1.2 nto-x86-low.c
--- gdb/gdbserver/nto-x86-low.c 1 Jan 2010 07:31:49 -0000 1.2
+++ gdb/gdbserver/nto-x86-low.c 20 Apr 2010 20:32:12 -0000
@@ -17,7 +17,7 @@
You should have received a copy of the GNU General Public License
along with this program. If not, see <http://www.gnu.org/licenses/>. */
-
+#include "server.h"
#include "nto-low.h"
#include "regdef.h"
#include "regcache.h"
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [patch] nto gdbserver
2010-04-20 20:43 ` Aleksandar Ristovski
@ 2010-04-20 20:49 ` Pedro Alves
2010-04-21 14:03 ` Aleksandar Ristovski
0 siblings, 1 reply; 6+ messages in thread
From: Pedro Alves @ 2010-04-20 20:49 UTC (permalink / raw)
To: gdb-patches; +Cc: Aleksandar Ristovski
On Tuesday 20 April 2010 21:43:29, Aleksandar Ristovski wrote:
> * Makefile.in (nto_low_h nto-low.o nto-x86-low.o): New dependency lists.
> * nto-x86-low.c: Include server.h
* Makefile.in (nto_low_h): New variable.
(nto-low.o, nto-x86-low.o): New rules.
* nto-x86-low.c: Include server.h
Okay with that entry. Thanks.
--
Pedro Alves
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [patch] nto gdbserver
2010-04-20 20:49 ` Pedro Alves
@ 2010-04-21 14:03 ` Aleksandar Ristovski
0 siblings, 0 replies; 6+ messages in thread
From: Aleksandar Ristovski @ 2010-04-21 14:03 UTC (permalink / raw)
To: gdb-patches
On Tue, 2010-04-20 at 21:49 +0100, Pedro Alves wrote:
> On Tuesday 20 April 2010 21:43:29, Aleksandar Ristovski wrote:
> > * Makefile.in (nto_low_h nto-low.o nto-x86-low.o): New dependency lists.
> > * nto-x86-low.c: Include server.h
>
> * Makefile.in (nto_low_h): New variable.
> (nto-low.o, nto-x86-low.o): New rules.
> * nto-x86-low.c: Include server.h
>
> Okay with that entry. Thanks.
>
Committed.
Thanks,
--
Aleksandar Ristovski
QNX Software Systems
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2010-04-21 14:03 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-04-20 17:16 [patch] nto gdbserver Aleksandar Ristovski
2010-04-20 19:52 ` Pedro Alves
2010-04-20 20:24 ` Aleksandar Ristovski
2010-04-20 20:43 ` Aleksandar Ristovski
2010-04-20 20:49 ` Pedro Alves
2010-04-21 14:03 ` Aleksandar Ristovski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox