Re: [PING][PATCH] Add support for accessing VFP registers to ARM native Linux

[Richard Earnshaw <rearnsha@arm.com>]

On Mon, 2010-03-15 at 14:48 +0000, Matthew Gretton-Dann wrote:
> All,
> 
> The attached patch adds support for VFP registers to GDB running
> natively under ARM Linux.  The patch is based in large part on the
> equivalent functionality in gdbserver for remote debugging of ARM Linux.
> 
> I have tested it with arm-unknown-linux-gnueabi on a target with Neon,
> one with VFPv3-D16, one with VFPv2, and a target without VFP.  I have
> also tested it on arm-none-linux on a target without VFP.  The patch has
> not been tested on an XScale as I do not have access to an appropriate
> device.
> 
> Can someone please review the patch, comment, and if appropriate commit
> it?
> 
> Proposed ChangeLog: 
> 
> 2010-03-01  Matthew Gretton-Dann  <matthew.gretton-dann@arm.com>
> 
> 	* arm-tdep.h (gdb_regnum): Add ARM_FPSCR_REGNUM
> 	* arm-linux-nat.c (arm_linux_vfp_register_count): Add new
> 	variable.
> 	(fetch_vfp_registers): New function to fetch VFP registers.
> 	(store_vfp_registers): New function to store VFP registers.
> 	(arm_linux_fetch_inferior_registers): Add support for VFP
> 	registers.
> 	(arm_linux_store_inferior_registers): Likewise.
> 	(arm_linux_read_description): Likewise.
> 	(arm_read_auxv, arm_get_hwcap): New function.
> 	(_initialize_arm_linux_nat): Delay initialising iWMMX tdesc
> 	until we need it.
> 
> Thanks,

OK once you've fixed:

+static void
+store_vfp_regs (const struct regcache *regcache)
...
+      warning (_("Unable to fetch VFPv3 registers."));
                             ^^^^^
s/fetch/store/