From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27797 invoked by alias); 19 Mar 2010 11:22:00 -0000 Received: (qmail 27786 invoked by uid 22791); 19 Mar 2010 11:21:59 -0000 X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from cam-admin0.cambridge.arm.com (HELO cam-admin0.cambridge.arm.com) (217.140.96.50) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 19 Mar 2010 11:21:52 +0000 Received: from cam-owa1.Emea.Arm.com (cam-owa1.emea.arm.com [10.1.255.62]) by cam-admin0.cambridge.arm.com (8.12.6/8.12.6) with ESMTP id o2JBLneI004931 for ; Fri, 19 Mar 2010 11:21:50 GMT Received: from [10.1.69.80] ([10.1.255.212]) by cam-owa1.Emea.Arm.com with Microsoft SMTPSVC(6.0.3790.0); Fri, 19 Mar 2010 11:21:49 +0000 Subject: Re: [PING][PATCH] Add support for accessing VFP registers to ARM native Linux From: Richard Earnshaw To: Matthew Gretton-Dann Cc: gdb-patches@sourceware.org In-Reply-To: <1268664534.12300.0.camel@e102111-lin.cambridge.arm.com> References: <1268664534.12300.0.camel@e102111-lin.cambridge.arm.com> Content-Type: text/plain Date: Fri, 19 Mar 2010 11:22:00 -0000 Message-Id: <1268997709.6009.11.camel@e200601-lin.cambridge.arm.com> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-03/txt/msg00726.txt.bz2 On Mon, 2010-03-15 at 14:48 +0000, Matthew Gretton-Dann wrote: > All, > > The attached patch adds support for VFP registers to GDB running > natively under ARM Linux. The patch is based in large part on the > equivalent functionality in gdbserver for remote debugging of ARM Linux. > > I have tested it with arm-unknown-linux-gnueabi on a target with Neon, > one with VFPv3-D16, one with VFPv2, and a target without VFP. I have > also tested it on arm-none-linux on a target without VFP. The patch has > not been tested on an XScale as I do not have access to an appropriate > device. > > Can someone please review the patch, comment, and if appropriate commit > it? > > Proposed ChangeLog: > > 2010-03-01 Matthew Gretton-Dann > > * arm-tdep.h (gdb_regnum): Add ARM_FPSCR_REGNUM > * arm-linux-nat.c (arm_linux_vfp_register_count): Add new > variable. > (fetch_vfp_registers): New function to fetch VFP registers. > (store_vfp_registers): New function to store VFP registers. > (arm_linux_fetch_inferior_registers): Add support for VFP > registers. > (arm_linux_store_inferior_registers): Likewise. > (arm_linux_read_description): Likewise. > (arm_read_auxv, arm_get_hwcap): New function. > (_initialize_arm_linux_nat): Delay initialising iWMMX tdesc > until we need it. > > Thanks, OK once you've fixed: +static void +store_vfp_regs (const struct regcache *regcache) ... + warning (_("Unable to fetch VFPv3 registers.")); ^^^^^ s/fetch/store/