From: Luis Machado <luisgpm@linux.vnet.ibm.com>
To: Joel Brobecker <brobecker@adacore.com>
Cc: Thiago Jung Bauermann <bauerman@br.ibm.com>,
gdb-patches@sourceware.org,
Matt Tyrlik <tyrlik@us.ibm.com>
Subject: Re: [PATCH 3/4] Support ranged and masked watchpoints
Date: Tue, 12 Jan 2010 13:56:00 -0000 [thread overview]
Message-ID: <1263297701.18167.7.camel@gargoyle> (raw)
In-Reply-To: <20100112105942.GL2007@adacore.com>
On Tue, 2010-01-12 at 14:59 +0400, Joel Brobecker wrote:
> > > Adds support for the following types of watchpoints:
> [range watchpoints]
>
> In this instance as well, I would like to see if we could push all
> the logic to the target, by providing all the information the target
> needs in order to make that decision.
>
> One nice upside is that this will allow the target to use both range
> watchpoint and condition hardware acceleration if the target allows it.
> Or if it doesn't, not separating the two types of features with
> separate target watchpoint_insert/remove routines allows the target
> to choose which one makes most sense if a choice needs to be made.
>
> What do you think?
>
The overall idea of pushing all the code that is closer to the target
somewhere more suitable sounds good to me. That way we can keep the
generic portion of GDB clean, which is less painful to maintain.
This would probably depend on the target vector facelift?
Regards,
Luis
next prev parent reply other threads:[~2010-01-12 13:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-24 0:32 Thiago Jung Bauermann
2010-01-04 17:33 ` Thiago Jung Bauermann
2010-01-12 11:00 ` Joel Brobecker
2010-01-12 13:56 ` Luis Machado [this message]
2010-01-12 18:06 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1263297701.18167.7.camel@gargoyle \
--to=luisgpm@linux.vnet.ibm.com \
--cc=bauerman@br.ibm.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=tyrlik@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox