From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10215 invoked by alias); 12 Jan 2010 13:56:49 -0000 Received: (qmail 10197 invoked by uid 22791); 12 Jan 2010 13:56:48 -0000 X-SWARE-Spam-Status: No, hits=-2.1 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from e24smtp02.br.ibm.com (HELO e24smtp02.br.ibm.com) (32.104.18.86) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 12 Jan 2010 13:56:44 +0000 Received: from mailhub1.br.ibm.com (mailhub1.br.ibm.com [9.18.232.109]) by e24smtp02.br.ibm.com (8.14.3/8.13.1) with ESMTP id o0CE2tcC022179 for ; Tue, 12 Jan 2010 12:02:55 -0200 Received: from d24av03.br.ibm.com (d24av03.br.ibm.com [9.8.31.95]) by mailhub1.br.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id o0CDwnHq786646 for ; Tue, 12 Jan 2010 11:58:49 -0200 Received: from d24av03.br.ibm.com (loopback [127.0.0.1]) by d24av03.br.ibm.com (8.14.3/8.13.1/NCO v10.0 AVout) with ESMTP id o0CDueb0026735 for ; Tue, 12 Jan 2010 11:56:40 -0200 Received: from [9.18.202.196] ([9.18.202.196]) by d24av03.br.ibm.com (8.14.3/8.13.1/NCO v10.0 AVin) with ESMTP id o0CDudYm026724 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 12 Jan 2010 11:56:39 -0200 Subject: Re: [PATCH 3/4] Support ranged and masked watchpoints From: Luis Machado Reply-To: luisgpm@linux.vnet.ibm.com To: Joel Brobecker Cc: Thiago Jung Bauermann , gdb-patches@sourceware.org, Matt Tyrlik In-Reply-To: <20100112105942.GL2007@adacore.com> References: <200912232231.06331.bauerman@br.ibm.com> <200912311520.36690.bauerman@br.ibm.com> <20100112105942.GL2007@adacore.com> Content-Type: text/plain; charset="UTF-8" Date: Tue, 12 Jan 2010 13:56:00 -0000 Message-ID: <1263297701.18167.7.camel@gargoyle> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-01/txt/msg00303.txt.bz2 On Tue, 2010-01-12 at 14:59 +0400, Joel Brobecker wrote: > > > Adds support for the following types of watchpoints: > [range watchpoints] > > In this instance as well, I would like to see if we could push all > the logic to the target, by providing all the information the target > needs in order to make that decision. > > One nice upside is that this will allow the target to use both range > watchpoint and condition hardware acceleration if the target allows it. > Or if it doesn't, not separating the two types of features with > separate target watchpoint_insert/remove routines allows the target > to choose which one makes most sense if a choice needs to be made. > > What do you think? > The overall idea of pushing all the code that is closer to the target somewhere more suitable sounds good to me. That way we can keep the generic portion of GDB clean, which is less painful to maintain. This would probably depend on the target vector facelift? Regards, Luis