From: Richard Earnshaw <rearnsha@arm.com>
To: Michael Snyder <msnyder@vmware.com>
Cc: "Maciej W. Rozycki" <macro@codesourcery.com>,
"gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [PING][PATCH] ARM/Linux: Unwind restart_syscall(2) frames
Date: Tue, 22 Dec 2009 15:28:00 -0000 [thread overview]
Message-ID: <1261495721.26179.67.camel@e200601-lin.cambridge.arm.com> (raw)
In-Reply-To: <4B2BD8CE.9010802@vmware.com>
On Fri, 2009-12-18 at 11:32 -0800, Michael Snyder wrote:
> Maciej W. Rozycki wrote:
> > Hi,
> >
> > Would anyone please review this patch:
> >
> > http://sourceware.org/ml/gdb-patches/2009-08/msg00431.html
> >
> > Thanks,
> >
> > Maciej
>
> Well, I don't see anything glaringly wrong with it...
>
> Richard?
>
>
It's not code that I'm familiar with, however...
svc 0x00900000
ldr pc, [sp], #12
then
+ trad_frame_set_reg_value (this_cache, ARM_SP_REGNUM, sp + 12);
So why is the stack pointer /incremented/ by 12 at this point (which
deallocates stack) rather than decremented to compensate for the
increment that will follow? Also, shouldn't the stack allocation be a
multiple of 8 to fully conform to the ABI stack alignment constraints?
What about thumb support?
Finally, do you need different code for Big-endian and BE-8 modes?
R.
next prev parent reply other threads:[~2009-12-22 15:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-18 14:13 Maciej W. Rozycki
2009-12-18 19:35 ` Michael Snyder
2009-12-22 15:28 ` Richard Earnshaw [this message]
2009-12-22 16:17 ` Daniel Jacobowitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1261495721.26179.67.camel@e200601-lin.cambridge.arm.com \
--to=rearnsha@arm.com \
--cc=gdb-patches@sourceware.org \
--cc=macro@codesourcery.com \
--cc=msnyder@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox