Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Thiago Jung Bauermann <bauerman@br.ibm.com>
To: Ulrich Weigand <uweigand@de.ibm.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [rfc] Eliminate duplicated logic with decimal operations
Date: Wed, 03 Jun 2009 14:27:00 -0000	[thread overview]
Message-ID: <1244039252.13165.4.camel@hactar> (raw)
In-Reply-To: <200905141132.n4EBWMrT030112@d12av02.megacenter.de.ibm.com>

Hi Uli,

Em Qui, 2009-05-14 às 13:32 +0200, Ulrich Weigand escreveu:
> The patch below removes steps 2 and 3 and only keeps the first
> conversion to decNumber.  This applies to both decimal_binop and 
> decimal_compare.
> 
> Thiago, any thoughts on this?  Do you agree that those conversions
> are unnecessary?

Thanks for this improvement! I agree with you, those are silly
conversions.

> Tested on powerpc64-linux with no regressions.

Silly question: you ran the testsuite with a DFP-capable compiler
right? :-)

dfp-exprs.exp has promotion tests, so your patch is certainly good.
-- 
[]'s
Thiago Jung Bauermann
IBM Linux Technology Center


  reply	other threads:[~2009-06-03 14:27 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-14 11:32 Ulrich Weigand
2009-06-03 14:27 ` Thiago Jung Bauermann [this message]
2009-06-03 17:49   ` Ulrich Weigand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1244039252.13165.4.camel@hactar \
    --to=bauerman@br.ibm.com \
    --cc=gdb-patches@sourceware.org \
    --cc=uweigand@de.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox