From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26265 invoked by alias); 3 Jun 2009 14:27:50 -0000 Received: (qmail 26171 invoked by uid 22791); 3 Jun 2009 14:27:49 -0000 X-SWARE-Spam-Status: No, hits=-2.7 required=5.0 tests=AWL,BAYES_00,SPF_PASS X-Spam-Check-By: sourceware.org Received: from e24smtp01.br.ibm.com (HELO e24smtp01.br.ibm.com) (32.104.18.85) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 03 Jun 2009 14:27:42 +0000 Received: from mailhub1.br.ibm.com (mailhub1.br.ibm.com [9.18.232.109]) by e24smtp01.br.ibm.com (8.13.1/8.13.1) with ESMTP id n53EmiMe016307 for ; Wed, 3 Jun 2009 11:48:44 -0300 Received: from d24av02.br.ibm.com (d24av02.br.ibm.com [9.18.232.47]) by mailhub1.br.ibm.com (8.13.8/8.13.8/NCO v9.2) with ESMTP id n53ES1E31552396 for ; Wed, 3 Jun 2009 11:28:01 -0300 Received: from d24av02.br.ibm.com (loopback [127.0.0.1]) by d24av02.br.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id n53ERZP5009102 for ; Wed, 3 Jun 2009 11:27:35 -0300 Received: from [9.8.5.50] ([9.8.5.50]) by d24av02.br.ibm.com (8.12.11.20060308/8.12.11) with ESMTP id n53ERZgY009080; Wed, 3 Jun 2009 11:27:35 -0300 Subject: Re: [rfc] Eliminate duplicated logic with decimal operations From: Thiago Jung Bauermann To: Ulrich Weigand Cc: gdb-patches@sourceware.org In-Reply-To: <200905141132.n4EBWMrT030112@d12av02.megacenter.de.ibm.com> References: <200905141132.n4EBWMrT030112@d12av02.megacenter.de.ibm.com> Content-Type: text/plain; charset="UTF-8" Date: Wed, 03 Jun 2009 14:27:00 -0000 Message-Id: <1244039252.13165.4.camel@hactar> Mime-Version: 1.0 Content-Transfer-Encoding: 8bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-06/txt/msg00036.txt.bz2 Hi Uli, Em Qui, 2009-05-14 às 13:32 +0200, Ulrich Weigand escreveu: > The patch below removes steps 2 and 3 and only keeps the first > conversion to decNumber. This applies to both decimal_binop and > decimal_compare. > > Thiago, any thoughts on this? Do you agree that those conversions > are unnecessary? Thanks for this improvement! I agree with you, those are silly conversions. > Tested on powerpc64-linux with no regressions. Silly question: you ran the testsuite with a DFP-capable compiler right? :-) dfp-exprs.exp has promotion tests, so your patch is certainly good. -- []'s Thiago Jung Bauermann IBM Linux Technology Center