Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Thiago Jung Bauermann <bauerman@br.ibm.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: tromey@redhat.com, gdb-patches@sourceware.org, drow@false.org
Subject: Re: [rfa][testsuite] Consolidade Python test functions in   lib/gdb.exp.
Date: Tue, 19 May 2009 14:50:00 -0000	[thread overview]
Message-ID: <1242744639.10143.6.camel@localhost.localdomain> (raw)
In-Reply-To: <83ws8ep9gq.fsf@gnu.org>

El lun, 18-05-2009 a las 21:11 +0300, Eli Zaretskii escribió:
> > gdb/testsuite/
> > 	* lib/python-support.exp: New file.
> > 	* lib/gdb.exp: Load python-support.exp.
> > 	* gdb.python/python-cmd.exp: Use Python test functions from
> > 	lib/python-support.exp instead of defining its own functions.
> > 	* gdb.python/python-frame.exp: Likewise.
> > 	* gdb.python/python-function.exp: Likewise.
> > 	* gdb.python/python-value.exp: Likewise.
> > 	* gdb.python/python.exp: Likewise.
> 
> Btw, is it possible to rename these files so as to avoid file-name
> clashes on 8+3 filesystems, as in python-frame.exp and
> python-function.exp (and the need to tweak config/djgpp/fnchange.lst
> accordingly)?  The name `gdb.python' already tells that this is about
> Python, so there should be no need for the "python-" name prefix for
> the files therein, right?

Yes, I agree with you. I used this naming scheme just to follow the
naming scheme used in the gdb/python directory. I don't actually like
the filenames there, for the same reason. I just use it to comply with a
request when the first Python patch was accepted. I don't dislike it
enough to argue and ask for changes though.

What do you think? Is it just fine to have the testcase files named
differently from the source files? There's not a strict 1:1 mapping
between them, but it's close.
-- 
[]'s
Thiago Jung Bauermann
IBM Linux Technology Center


  reply	other threads:[~2009-05-19 14:50 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-19 15:21 Thiago Jung Bauermann
2009-04-20 17:13 ` Tom Tromey
2009-04-20 17:23   ` Daniel Jacobowitz
2009-05-18  4:38   ` Thiago Jung Bauermann
2009-05-18 18:11     ` Eli Zaretskii
2009-05-19 14:50       ` Thiago Jung Bauermann [this message]
2009-05-19 14:59         ` Daniel Jacobowitz
2009-05-19 19:22           ` Eli Zaretskii
2009-05-19 22:21             ` Thiago Jung Bauermann
2009-05-20  3:11               ` Eli Zaretskii
2009-05-20  3:26                 ` Thiago Jung Bauermann
2009-05-20  3:39                   ` Daniel Jacobowitz
2009-05-20 13:18                     ` Thiago Jung Bauermann
2009-05-20 14:59                       ` Daniel Jacobowitz
2009-05-20 15:10                         ` Thiago Jung Bauermann
2009-05-20 17:22                           ` Eli Zaretskii
2009-05-20 19:39                             ` Thiago Jung Bauermann
2009-05-20 20:00                               ` Eli Zaretskii
2009-05-20 20:49                                 ` Thiago Jung Bauermann
2009-05-20 23:11                                   ` Joel Brobecker
2009-05-31 22:26                                 ` Thiago Jung Bauermann
2009-05-31 22:37                                   ` Thiago Jung Bauermann
2009-06-04 18:03                                   ` Tom Tromey
2009-05-28  0:43                           ` Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1242744639.10143.6.camel@localhost.localdomain \
    --to=bauerman@br.ibm.com \
    --cc=drow@false.org \
    --cc=eliz@gnu.org \
    --cc=gdb-patches@sourceware.org \
    --cc=tromey@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox