From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19207 invoked by alias); 19 May 2009 14:50:57 -0000 Received: (qmail 19199 invoked by uid 22791); 19 May 2009 14:50:56 -0000 X-SWARE-Spam-Status: No, hits=-2.7 required=5.0 tests=AWL,BAYES_00,SPF_PASS X-Spam-Check-By: sourceware.org Received: from e24smtp04.br.ibm.com (HELO e24smtp04.br.ibm.com) (32.104.18.25) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 19 May 2009 14:50:50 +0000 Received: from mailhub3.br.ibm.com (mailhub3.br.ibm.com [9.18.232.110]) by e24smtp04.br.ibm.com (8.13.1/8.13.1) with ESMTP id n4JEo4Vu015592 for ; Tue, 19 May 2009 11:50:04 -0300 Received: from d24av02.br.ibm.com (d24av02.br.ibm.com [9.18.232.47]) by mailhub3.br.ibm.com (8.13.8/8.13.8/NCO v9.2) with ESMTP id n4JEp9H11974338 for ; Tue, 19 May 2009 11:51:09 -0300 Received: from d24av02.br.ibm.com (loopback [127.0.0.1]) by d24av02.br.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id n4JEohWx019756 for ; Tue, 19 May 2009 11:50:44 -0300 Received: from [9.8.1.201] ([9.8.1.201]) by d24av02.br.ibm.com (8.12.11.20060308/8.12.11) with ESMTP id n4JEoggF019643; Tue, 19 May 2009 11:50:43 -0300 Subject: Re: [rfa][testsuite] Consolidade Python test functions in lib/gdb.exp. From: Thiago Jung Bauermann To: Eli Zaretskii Cc: tromey@redhat.com, gdb-patches@sourceware.org, drow@false.org In-Reply-To: <83ws8ep9gq.fsf@gnu.org> References: <1240154454.19777.39.camel@localhost.localdomain> <1242621476.8085.4.camel@hactar> <83ws8ep9gq.fsf@gnu.org> Content-Type: text/plain; charset="UTF-8" Date: Tue, 19 May 2009 14:50:00 -0000 Message-Id: <1242744639.10143.6.camel@localhost.localdomain> Mime-Version: 1.0 Content-Transfer-Encoding: 8bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-05/txt/msg00399.txt.bz2 El lun, 18-05-2009 a las 21:11 +0300, Eli Zaretskii escribió: > > gdb/testsuite/ > > * lib/python-support.exp: New file. > > * lib/gdb.exp: Load python-support.exp. > > * gdb.python/python-cmd.exp: Use Python test functions from > > lib/python-support.exp instead of defining its own functions. > > * gdb.python/python-frame.exp: Likewise. > > * gdb.python/python-function.exp: Likewise. > > * gdb.python/python-value.exp: Likewise. > > * gdb.python/python.exp: Likewise. > > Btw, is it possible to rename these files so as to avoid file-name > clashes on 8+3 filesystems, as in python-frame.exp and > python-function.exp (and the need to tweak config/djgpp/fnchange.lst > accordingly)? The name `gdb.python' already tells that this is about > Python, so there should be no need for the "python-" name prefix for > the files therein, right? Yes, I agree with you. I used this naming scheme just to follow the naming scheme used in the gdb/python directory. I don't actually like the filenames there, for the same reason. I just use it to comply with a request when the first Python patch was accepted. I don't dislike it enough to argue and ask for changes though. What do you think? Is it just fine to have the testcase files named differently from the source files? There's not a strict 1:1 mapping between them, but it's close. -- []'s Thiago Jung Bauermann IBM Linux Technology Center