Re: [PATCH 3/3] catch syscall -- try 5 -- Build-system, testcase, documentation and extra command

["Sérgio Durigan Júnior" <sergiodj@linux.vnet.ibm.com>]

Hi Eli,

On Sun, 2009-04-26 at 20:48 +0300, Eli Zaretskii wrote:
> > > > +Catchpoint 1 (call to syscall 'close'), \
> > > > +	   0xffffe424 in __kernel_vsyscall ()
> > > 
> > > > +Catchpoint 1 (returned from syscall 'close'), \
> > > > +	0xffffe424 in __kernel_vsyscall ()
> > > 
> > > Is this all GDB displays when a syscall is caught?  I thought it also
> > > displayed the return code and the syscall parameters, like strace
> > > does.  If we don't do that, this facility looks much less useful than
> > > it sounds, doesn't it?  I realize that the user could glean all that
> > > information by using the normal GDB commands, but for that, she would
> > > need to know the some intimate details of the syscall dispatched
> > > (__kernel_vsyscall in this case), right?
> > 
> > I'm sorry, but this is how the "catch syscall" was implemented since the
> > beginning.  For the moment, GDB only prints the syscall name when the
> > catchpoint is triggered; it's obviously my intention to expand this in
> > the future (by making GDB print the syscall arguments, or its return
> > value for example), but I unfortunately don't have time to do it now.
> 
> That's fine with me.  Please don't regard my comments as rejection of
> what you've done.


Sorry if this sounded too personal.  It was not my intention.

Thanks for the review, I'll send a refreshed patch probably today.

Regards,

-- 
Sérgio Durigan Júnior
Linux on Power Toolchain - Software Engineer
Linux Technology Center - LTC
IBM Brazil