From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 812 invoked by alias); 26 Apr 2009 17:55:31 -0000 Received: (qmail 803 invoked by uid 22791); 26 Apr 2009 17:55:30 -0000 X-SWARE-Spam-Status: No, hits=-2.1 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from e24smtp04.br.ibm.com (HELO e24smtp04.br.ibm.com) (32.104.18.25) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sun, 26 Apr 2009 17:55:25 +0000 Received: from mailhub3.br.ibm.com (mailhub3.br.ibm.com [9.18.232.110]) by e24smtp04.br.ibm.com (8.13.1/8.13.1) with ESMTP id n3QHogj8011711 for ; Sun, 26 Apr 2009 14:50:42 -0300 Received: from d24av02.br.ibm.com (d24av02.br.ibm.com [9.18.232.47]) by mailhub3.br.ibm.com (8.13.8/8.13.8/NCO v9.2) with ESMTP id n3QHtiJM848076 for ; Sun, 26 Apr 2009 14:55:44 -0300 Received: from d24av02.br.ibm.com (loopback [127.0.0.1]) by d24av02.br.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id n3QHtLEG023950 for ; Sun, 26 Apr 2009 14:55:21 -0300 Received: from [9.18.198.222] ([9.18.198.222]) by d24av02.br.ibm.com (8.12.11.20060308/8.12.11) with ESMTP id n3QHtLw7023943; Sun, 26 Apr 2009 14:55:21 -0300 Subject: Re: [PATCH 3/3] catch syscall -- try 5 -- Build-system, testcase, documentation and extra command From: =?ISO-8859-1?Q?S=E9rgio?= Durigan =?ISO-8859-1?Q?J=FAnior?= To: Eli Zaretskii Cc: gdb-patches@sourceware.org In-Reply-To: <8363grfgr5.fsf@gnu.org> References: <1240446783.2000.83.camel@miki> <83prf1f7hb.fsf@gnu.org> <1240731135.13755.19.camel@miki> <8363grfgr5.fsf@gnu.org> Content-Type: text/plain; charset="ISO-8859-1" Date: Sun, 26 Apr 2009 17:55:00 -0000 Message-Id: <1240768520.13755.21.camel@miki> Mime-Version: 1.0 Content-Transfer-Encoding: 8bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-04/txt/msg00719.txt.bz2 Hi Eli, On Sun, 2009-04-26 at 20:48 +0300, Eli Zaretskii wrote: > > > > +Catchpoint 1 (call to syscall 'close'), \ > > > > + 0xffffe424 in __kernel_vsyscall () > > > > > > > +Catchpoint 1 (returned from syscall 'close'), \ > > > > + 0xffffe424 in __kernel_vsyscall () > > > > > > Is this all GDB displays when a syscall is caught? I thought it also > > > displayed the return code and the syscall parameters, like strace > > > does. If we don't do that, this facility looks much less useful than > > > it sounds, doesn't it? I realize that the user could glean all that > > > information by using the normal GDB commands, but for that, she would > > > need to know the some intimate details of the syscall dispatched > > > (__kernel_vsyscall in this case), right? > > > > I'm sorry, but this is how the "catch syscall" was implemented since the > > beginning. For the moment, GDB only prints the syscall name when the > > catchpoint is triggered; it's obviously my intention to expand this in > > the future (by making GDB print the syscall arguments, or its return > > value for example), but I unfortunately don't have time to do it now. > > That's fine with me. Please don't regard my comments as rejection of > what you've done. Sorry if this sounded too personal. It was not my intention. Thanks for the review, I'll send a refreshed patch probably today. Regards, -- Sérgio Durigan Júnior Linux on Power Toolchain - Software Engineer Linux Technology Center - LTC IBM Brazil