From: Thiago Jung Bauermann <bauerman@br.ibm.com>
To: Daniel Mierswa <impulze@impulze.org>
Cc: gdb-patches@sourceware.org
Subject: Re: autotools patches for --*dir and upcoming versions
Date: Thu, 20 Nov 2008 13:28:00 -0000 [thread overview]
Message-ID: <1227156450.28256.128.camel@localhost.localdomain> (raw)
In-Reply-To: <491F6FAB.6020305@impulze.org>
Hi,
I'm far from what you'd call an autotools person, so I won't comment on
the actual changes you are proposing, just give some general information
on how I'd go about this.
First of all, thanks for your patch, of course.
GDB shares its source tree with other projects, and a number of the
directories it ships in its tarball are actually managed by those other
projects. So you'll have to talk to people in other mailing lists as
well, I'm afraid. For instance (I'm not even sure about some of them
myself):
Files in the root of the tarball I believe are responsibility of the GCC
project (also, you'd have to reflect your changes in the gcc build
system as well), and so are files under libdecnumber/. Files under bfd/
are from binutils, gdb/ and sim/ you can talk about them here, and files
under readline/ are from the readline project. I don't know about files
under intl/ and libiberty/. I'd guess either binutils or GCC...
Also, I'm sure everybody will ask a diff against a recent CVS (or svn)
version. But you can worry about that after discussing your proposed
changes, so that you don't have to do more work than necessary.
--
[]'s
Thiago Jung Bauermann
IBM Linux Technology Center
El dom, 16-11-2008 a las 01:56 +0100, Daniel Mierswa escribió:
> I created a patch to let the --{dataroot,doc,pdf,html}dir to be passed
> through configure instead of using the self written --with-*dir.
> The patch also fixes some warnings spilled out by newer autotools
> regarding ordering of AC_ macros and unquoted definitions.
> The patch was created against the official 6.8 tarball.
> Tested by invoking the usual, autoreconf procedures, followed by
> ./configure with --docdir=/something and invoking make install-html at
> the very end.
> I'd like to hear your opinion.
> The ChangeLog entries would be as follows:
>
> ChangeLog: (couldn't find any)
> 2008-11-15 Daniel Mierswa <impulze@impulze.org>
> * configure.ac: use config directory for m4-macro searches, provide
> AC_PROG_LIBTOOL, so ltmain.sh and others get updated by autoreconf,
> remove self-written --with-{dataroot,doc,pdf,html}dir switches and
> let the
> ones created by autoconf pass through, remove unneeded AC_SUBST
>
> bfd/ChangeLog:
> 2008-11-15 Daniel Mierswa <impulze@impulze.org>
> * configure.in: AC_GNU_SOURCE must occur before AC_PROG_CC,
> use own directory for m4-macro searches, remove unneeded AC_SUBST
>
> gdb/ChangeLog:
> 2008-11-15 Daniel Mierswa <impulze@impulze.org>
> * configure.ac: AC_{GNU_SOURCE,AIX} are both present in
> AC_USE_SYSTEM_EXTENSIONS (must occur before AC_PROG_CC)
> * acinclude.m4: serial has to appear before any macro definition
> * Makefile.in: touch datarootdir so autoconf is happy, don't
> redefine variables
> passed by configure
>
> gdb/doc/ChangeLog:
> 2008-11-15 Daniel Mierswa <impulze@impulze.org>
> * Makefile.in: don't redefine variables passed by configure, install
> html files
> from subdirectories
>
> gdb/gdbserver/ChangeLog:
> 2008-11-15 Daniel Mierswa <impulze@impulze.org>
> * Makefile.in: don't redefine variables passed by configure
>
> intl/ChangeLog:
> 2008-11-15 Daniel Mierswa <impulze@impulze.org>
> * Makefile.in: touch datarootdir so autoconf is happy
>
> libiberty/ChangeLog:
> 2008-11-15 Daniel Mierswa <impulze@impulze.org>
> * configure.ac: remove unneeded AC_SUBST
>
> sim/common/ChangeLog:
> 2008-11-15 Daniel Mierswa <impulze@impulze.org>
> * aclocal.m4: use quoted definitions, autoconf cached variables
> have to include cv in their name
>
> sim/ChangeLog:
> 2008-11-15 Daniel Mierswa <impulze@impulze.org>
> * configure.ac: use own directory for m4-macro searches
> * Makefile.in: touch datarootdir so autoconf is happy
>
> libdecnumber/ChangeLog:
> 2008-11-15 Daniel Mierswa <impulze@impulze.org>
> * Makefile.in: touch datarootdir so autoconf is happy
>
> readline/ChangeLog.gdb:
> 2008-11-15 Daniel Mierswa <impulze@impulze.org>
> * Makefile.in: touch datarootdir so autoconf is happy, create empty
> install-html target so make install-html from top-level won't fail
>
> readline/doc/ChangeLog.gdb:
> 2008-11-15 Daniel Mierswa <impulze@impulze.org>
> * Makefile.in: touch datarootdir so autoconf is happy
>
> readline/examples/rlfe/ChangeLog:
> 2008-11-15 Daniel Mierswa <impulze@impulze.org>
> * configure.in: use quoted definitions
>
> readline/shlib/ChangeLog.gdb: (couldn't find any)
> 2008-11-15 Daniel Mierswa <impulze@impulze.org>
> * Makefile.in: touch datarootdir so autoconf is happy
next prev parent reply other threads:[~2008-11-20 4:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-16 18:08 Daniel Mierswa
2008-11-20 13:28 ` Thiago Jung Bauermann [this message]
2008-11-22 18:22 ` Joel Brobecker
-- strict thread matches above, loose matches on Subject: below --
2008-11-16 17:37 Daniel Mierswa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1227156450.28256.128.camel@localhost.localdomain \
--to=bauerman@br.ibm.com \
--cc=gdb-patches@sourceware.org \
--cc=impulze@impulze.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox