From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19220 invoked by alias); 20 Nov 2008 04:48:32 -0000 Received: (qmail 19138 invoked by uid 22791); 20 Nov 2008 04:48:30 -0000 X-Spam-Check-By: sourceware.org Received: from igw1.br.ibm.com (HELO igw1.br.ibm.com) (32.104.18.24) by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 20 Nov 2008 04:47:34 +0000 Received: from d24relay01.br.ibm.com (unknown [9.8.31.16]) by igw1.br.ibm.com (Postfix) with ESMTP id DE14C32C01D for ; Thu, 20 Nov 2008 02:44:36 -0200 (BRDT) Received: from d24av01.br.ibm.com (d24av01.br.ibm.com [9.18.232.46]) by d24relay01.br.ibm.com (8.13.8/8.13.8/NCO v9.1) with ESMTP id mAK5l7aq3063854 for ; Thu, 20 Nov 2008 02:47:07 -0300 Received: from d24av01.br.ibm.com (loopback [127.0.0.1]) by d24av01.br.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id mAK4lVAB011080 for ; Thu, 20 Nov 2008 02:47:31 -0200 Received: from [9.8.3.184] ([9.8.3.184]) by d24av01.br.ibm.com (8.12.11.20060308/8.12.11) with ESMTP id mAK4lU2F011075; Thu, 20 Nov 2008 02:47:30 -0200 Subject: Re: autotools patches for --*dir and upcoming versions From: Thiago Jung Bauermann To: Daniel Mierswa Cc: gdb-patches@sourceware.org In-Reply-To: <491F6FAB.6020305@impulze.org> References: <491F6FAB.6020305@impulze.org> Content-Type: text/plain; charset=utf-8 Date: Thu, 20 Nov 2008 13:28:00 -0000 Message-Id: <1227156450.28256.128.camel@localhost.localdomain> Mime-Version: 1.0 X-Mailer: Evolution 2.22.3.1 Content-Transfer-Encoding: 8bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-11/txt/msg00539.txt.bz2 Hi, I'm far from what you'd call an autotools person, so I won't comment on the actual changes you are proposing, just give some general information on how I'd go about this. First of all, thanks for your patch, of course. GDB shares its source tree with other projects, and a number of the directories it ships in its tarball are actually managed by those other projects. So you'll have to talk to people in other mailing lists as well, I'm afraid. For instance (I'm not even sure about some of them myself): Files in the root of the tarball I believe are responsibility of the GCC project (also, you'd have to reflect your changes in the gcc build system as well), and so are files under libdecnumber/. Files under bfd/ are from binutils, gdb/ and sim/ you can talk about them here, and files under readline/ are from the readline project. I don't know about files under intl/ and libiberty/. I'd guess either binutils or GCC... Also, I'm sure everybody will ask a diff against a recent CVS (or svn) version. But you can worry about that after discussing your proposed changes, so that you don't have to do more work than necessary. -- []'s Thiago Jung Bauermann IBM Linux Technology Center El dom, 16-11-2008 a las 01:56 +0100, Daniel Mierswa escribió: > I created a patch to let the --{dataroot,doc,pdf,html}dir to be passed > through configure instead of using the self written --with-*dir. > The patch also fixes some warnings spilled out by newer autotools > regarding ordering of AC_ macros and unquoted definitions. > The patch was created against the official 6.8 tarball. > Tested by invoking the usual, autoreconf procedures, followed by > ./configure with --docdir=/something and invoking make install-html at > the very end. > I'd like to hear your opinion. > The ChangeLog entries would be as follows: > > ChangeLog: (couldn't find any) > 2008-11-15 Daniel Mierswa > * configure.ac: use config directory for m4-macro searches, provide > AC_PROG_LIBTOOL, so ltmain.sh and others get updated by autoreconf, > remove self-written --with-{dataroot,doc,pdf,html}dir switches and > let the > ones created by autoconf pass through, remove unneeded AC_SUBST > > bfd/ChangeLog: > 2008-11-15 Daniel Mierswa > * configure.in: AC_GNU_SOURCE must occur before AC_PROG_CC, > use own directory for m4-macro searches, remove unneeded AC_SUBST > > gdb/ChangeLog: > 2008-11-15 Daniel Mierswa > * configure.ac: AC_{GNU_SOURCE,AIX} are both present in > AC_USE_SYSTEM_EXTENSIONS (must occur before AC_PROG_CC) > * acinclude.m4: serial has to appear before any macro definition > * Makefile.in: touch datarootdir so autoconf is happy, don't > redefine variables > passed by configure > > gdb/doc/ChangeLog: > 2008-11-15 Daniel Mierswa > * Makefile.in: don't redefine variables passed by configure, install > html files > from subdirectories > > gdb/gdbserver/ChangeLog: > 2008-11-15 Daniel Mierswa > * Makefile.in: don't redefine variables passed by configure > > intl/ChangeLog: > 2008-11-15 Daniel Mierswa > * Makefile.in: touch datarootdir so autoconf is happy > > libiberty/ChangeLog: > 2008-11-15 Daniel Mierswa > * configure.ac: remove unneeded AC_SUBST > > sim/common/ChangeLog: > 2008-11-15 Daniel Mierswa > * aclocal.m4: use quoted definitions, autoconf cached variables > have to include cv in their name > > sim/ChangeLog: > 2008-11-15 Daniel Mierswa > * configure.ac: use own directory for m4-macro searches > * Makefile.in: touch datarootdir so autoconf is happy > > libdecnumber/ChangeLog: > 2008-11-15 Daniel Mierswa > * Makefile.in: touch datarootdir so autoconf is happy > > readline/ChangeLog.gdb: > 2008-11-15 Daniel Mierswa > * Makefile.in: touch datarootdir so autoconf is happy, create empty > install-html target so make install-html from top-level won't fail > > readline/doc/ChangeLog.gdb: > 2008-11-15 Daniel Mierswa > * Makefile.in: touch datarootdir so autoconf is happy > > readline/examples/rlfe/ChangeLog: > 2008-11-15 Daniel Mierswa > * configure.in: use quoted definitions > > readline/shlib/ChangeLog.gdb: (couldn't find any) > 2008-11-15 Daniel Mierswa > * Makefile.in: touch datarootdir so autoconf is happy