From: Thiago Jung Bauermann <bauerman@br.ibm.com>
To: Kevin Buettner <kevinb@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFC] PPC: Skip call to __eabi in main()
Date: Tue, 22 Jul 2008 04:45:00 -0000 [thread overview]
Message-ID: <1216701867.31797.26.camel@localhost.localdomain> (raw)
In-Reply-To: <20080721155343.404977d3@mesquite.lan>
On Mon, 2008-07-21 at 15:53 -0700, Kevin Buettner wrote:
> + if ((op & 0xfc000001) == 0x48000001)
> + {
> + CORE_ADDR displ = op & 0x03fffffc;
I think this would be more legible with #defines instead of these
hardcoded opcodes and bitmasks. Also, a comment above each #define
explaining what the value means, of course.
--
[]'s
Thiago Jung Bauermann
Software Engineer
IBM Linux Technology Center
next prev parent reply other threads:[~2008-07-22 4:45 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-21 22:54 Kevin Buettner
2008-07-22 4:45 ` Thiago Jung Bauermann [this message]
2008-07-23 1:13 ` Kevin Buettner
2008-07-29 0:22 ` Kevin Buettner
2008-08-01 18:46 ` Luis Machado
2008-08-07 0:42 ` Kevin Buettner
2008-08-07 14:04 ` Daniel Jacobowitz
2008-08-07 15:14 ` Luis Machado
2008-08-12 0:30 ` Kevin Buettner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1216701867.31797.26.camel@localhost.localdomain \
--to=bauerman@br.ibm.com \
--cc=gdb-patches@sourceware.org \
--cc=kevinb@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox