From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-57390-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 18606 invoked by alias); 22 Jul 2008 04:45:56 -0000
Received: (qmail 18595 invoked by uid 22791); 22 Jul 2008 04:45:55 -0000
X-Spam-Check-By: sourceware.org
Received: from igw2.br.ibm.com (HELO igw2.br.ibm.com) (32.104.18.25)     by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 22 Jul 2008 04:45:00 +0000
Received: from mailhub3.br.ibm.com (mailhub3 [9.18.232.110]) 	by igw2.br.ibm.com (Postfix) with ESMTP id 52A6B17F493 	for <gdb-patches@sourceware.org>; Tue, 22 Jul 2008 01:31:42 -0300 (BRT)
Received: from d24av01.br.ibm.com (d24av01.br.ibm.com [9.18.232.46]) 	by mailhub3.br.ibm.com (8.13.8/8.13.8/NCO v8.7) with ESMTP id m6M4iv9Q1953892 	for <gdb-patches@sourceware.org>; Tue, 22 Jul 2008 01:44:57 -0300
Received: from d24av01.br.ibm.com (loopback [127.0.0.1]) 	by d24av01.br.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id m6M4ip27027244 	for <gdb-patches@sourceware.org>; Tue, 22 Jul 2008 01:44:51 -0300
Received: from [9.18.198.195] ([9.18.198.195]) 	by d24av01.br.ibm.com (8.12.11.20060308/8.12.11) with ESMTP id m6M4imPQ027089; 	Tue, 22 Jul 2008 01:44:49 -0300
Subject: Re: [RFC] PPC: Skip call to __eabi in main()
From: Thiago Jung Bauermann <bauerman@br.ibm.com>
To: Kevin Buettner <kevinb@redhat.com>
Cc: gdb-patches@sourceware.org
In-Reply-To: <20080721155343.404977d3@mesquite.lan>
References: <20080721155343.404977d3@mesquite.lan>
Content-Type: text/plain
Date: Tue, 22 Jul 2008 04:45:00 -0000
Message-Id: <1216701867.31797.26.camel@localhost.localdomain>
Mime-Version: 1.0
X-Mailer: Evolution 2.22.3.1
Content-Transfer-Encoding: 7bit
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2008-07/txt/msg00402.txt.bz2

On Mon, 2008-07-21 at 15:53 -0700, Kevin Buettner wrote:
> +  if ((op & 0xfc000001) == 0x48000001)
> +    {
> +      CORE_ADDR displ = op & 0x03fffffc;

I think this would be more legible with #defines instead of these
hardcoded opcodes and bitmasks. Also, a comment above each #define
explaining what the value means, of course.
-- 
[]'s
Thiago Jung Bauermann
Software Engineer
IBM Linux Technology Center