From: Thiago Jung Bauermann <bauerman@br.ibm.com>
To: Joel Brobecker <brobecker@adacore.com>
Cc: GDB Patches <gdb-patches@sourceware.org>
Subject: Re: [RFC] Remove exec_set_section_offsets
Date: Sat, 19 Apr 2008 04:28:00 -0000 [thread overview]
Message-ID: <1208570812.5808.113.camel@localhost.localdomain> (raw)
In-Reply-To: <20080419015835.GN12735@adacore.com>
On Fri, 2008-04-18 at 18:58 -0700, Joel Brobecker wrote:
> > Perhaps it would qualify as obvious, but I'm not used to removing code
> > from GDB so better ask about it...
>
> We just have to remember that insight builds on top of GDB. So, just
> to be absolutely sure, I checked out the insight sources, and verified
> that it wasn't using that function. So far, the functions I've seen
> being used by insight started with a gdb_ prefix, but that might not
> be a rule.
Nice to know, thanks for the tip. So if I observe that, this kind of
patch fits the obvious rule?
> > 2008-04-18 Thiago Jung Bauermann <bauerman@br.ibm.com>
> >
> > * defs.h (exec_set_section_offsets): Remove prototype.
> > * exec.c (exec_set_section_offsets): Remove function.
>
> That's OK. Thank you!
Committed, thanks!
--
[]'s
Thiago Jung Bauermann
Software Engineer
IBM Linux Technology Center
next prev parent reply other threads:[~2008-04-19 2:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-19 0:34 Thiago Jung Bauermann
2008-04-19 4:28 ` Joel Brobecker
2008-04-19 4:28 ` Thiago Jung Bauermann [this message]
2008-04-19 5:57 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1208570812.5808.113.camel@localhost.localdomain \
--to=bauerman@br.ibm.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox